Michael Gmelin <[email protected]> writes: > Dag-Erling Smørgrav <[email protected]> writes: > > Some of the code in http.c is so deeply nested that it is almost > > impossible to stay within 80 characters. This is a clear sign that > > the code needs to be rewritten. > Ok, is that only for libfetch or for all of kernel (just for future > reference).
Not sure what you mean; libfetch is not part of the kernel, and deep nesting is almost always a symptom of poor structure or insufficient modularization. > Thanks for the detailed explanation. So do you think you could fix > these style issues yourself, or should I give it a shot (I'm certain I > will miss *some* of those issues but it will definitely get better). I could fix your mistakes, but then you wouldn't learn from them :) Contact me off-list when you have a new patch. DES -- Dag-Erling Smørgrav - [email protected] _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "[email protected]"
