On Sun, Oct 07, 2012 at 03:17:30PM +0300, Andriy Gapon wrote:
>
> I noticed that couple of our userland file include machine/cpu.h for no
> apparent
> good reason. It looks like at least amd64 cpu.h has no userland serviceable
> parts inside.
> Maybe its content should be put under _KERNEL ?
>
> Also:
>
> --- a/sbin/adjkerntz/adjkerntz.c
> +++ b/sbin/adjkerntz/adjkerntz.c
> @@ -51,7 +51,6 @@ __FBSDID("$FreeBSD$");
> #include <syslog.h>
> #include <sys/time.h>
> #include <sys/param.h>
> -#include <machine/cpu.h>
> #include <sys/sysctl.h>
>
> #include "pathnames.h"
> diff --git a/usr.bin/w/w.c b/usr.bin/w/w.c
> index 8441ce5..9674fc2 100644
> --- a/usr.bin/w/w.c
> +++ b/usr.bin/w/w.c
> @@ -57,7 +57,6 @@ static const char sccsid[] = "@(#)w.c 8.4 (Berkeley)
> 4/16/94";
> #include <sys/socket.h>
> #include <sys/tty.h>
>
> -#include <machine/cpu.h>
> #include <netinet/in.h>
> #include <arpa/inet.h>
> #include <arpa/nameser.h>Both proposals are obviously fine. Some research with git blame traces the include presence in the w.c to the 4.4 Lite import. What I do not understand is why do you spam lists instead of commmitting the obvious changes ?
pgpzUWzFXZ6GB.pgp
Description: PGP signature
