Barney Wolff wrote:
On Sat, Mar 01, 2003 at 11:09:03PM +0100, Jens Rehsack wrote:

Shouldn't we care about u_char vs char?  On some machines it matters,
and on all machines compilers tend to notice and generate warnings.

Yes, usually we should. But I reviewed the code and didn't found a reason for using 'unsigned char'. I got compiler warning ('couse I have them enabled all) during compiling the file before I have finished the patch. But most of the code relies on 'char' and 'u_char' was used for storing chars only. Do you know any machine which stores signed chars different than unsigned chars?


But the mixing - which was in it before - was not acceptable.

Jens


To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message

Reply via email to