On 03:18+0200, Feb 18, 2003, Giorgos Keramidas wrote:
> On 2003-02-18 00:02, Wiktor Niesiobedzki <[EMAIL PROTECTED]> wrote:
> > On Mon, Feb 17, 2003 at 11:47:32PM +0100, Wiktor Niesiobedzki wrote:
> > There is an obvious mistake in patch (or change in ip_fw2.c should
> > be considered).
> > [...]
> > --- sys/kern/uipc_socket.c 2003/02/17 22:37:58 1.144
> > +++ sys/kern/uipc_socket.c 2003/02/17 22:56:41
> > @@ -1846,8 +1846,8 @@
> > {
> >
> > if (so == NULL)
> > - return (EPERM);
> > - if (so->so_cred->cr_uid == uid)
> > return (0);
> > - return (EPERM);
> > + if (so->so_cred->cr_uid == uid)
> > + return (1);
> > + return (0);
> > }
>
> The rest of the uipc_socket.c functions (socreate, sobind, solisten,
> soclose, soabort, ...) that return int's use zero as a "success"
> value, and return errno based errors otherwise. I'm thinking if the
> error is ipfw2's fault and should be fixed there. It seems slightly
> preferable to me.
Yes, I have already fixed this bug in rev.1.26 src/sys/netinet/ip_fw2.c
--
Maxim Konovalov, [EMAIL PROTECTED], [EMAIL PROTECTED]
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
