On Sun, 2003/02/09 at 14:39:36 +1100, Tim Robbins wrote:
> On Sat, Feb 08, 2003 at 02:04:56PM -0800, Kris Kennaway wrote:
>
> > On Sat, Feb 08, 2003 at 04:12:26PM +0100, Thomas Moestl wrote:
> >
> > > addr2line will usually point to the first line of a statement if it
> > > spans multiple lines; in this case, the full guard is:
> > >
> > > while (p2->p_pid == trypid ||
> > > p2->p_pgrp->pg_id == trypid ||
> > > p2->p_session->s_sid == trypid) {
> >
> > OK, I suspected that.
> >
> > tjr was looking into this last night and proposed the following patch:
>
> Alfred was the one who pointed out that holding proctree was probably
> necessary, though :-)
I don't really get why this is required - the pg_session pointer in
struct pgrp is constant over the pgrp's lifetime, so for it to be
invalid the wrong struct pgrp must be referenced; the p_pgrp pointer
is protected by the process lock however, which is held for this check.
- Thomas
--
Thomas Moestl <[EMAIL PROTECTED]> http://www.tu-bs.de/~y0015675/
<[EMAIL PROTECTED]> http://people.FreeBSD.org/~tmm/
PGP fingerprint: 1C97 A604 2BD0 E492 51D0 9C0F 1FE6 4F1D 419C 776C
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
