I've partially ported the NetBSD busdma code for USB to FreeBSD, but
it doesn't compile, probably for a trivial reason.

Anyone fancy helping me out?

Joe
p.s. patches attached
-- 
Josef Karthauser ([EMAIL PROTECTED])              http://www.josef-k.net/
FreeBSD (cvs meister, admin and hacker)     http://www.uk.FreeBSD.org/
Physics Particle Theory (student)   http://www.pact.cpes.sussex.ac.uk/
================ An eclectic mix of fact and theory. =================
Index: conf/files
===================================================================
RCS file: /home/ncvs/src/sys/conf/files,v
retrieving revision 1.744
diff -u -r1.744 files
--- conf/files  8 Jan 2003 23:36:59 -0000       1.744
+++ conf/files  15 Jan 2003 19:35:10 -0000
@@ -758,7 +758,7 @@
 dev/usb/uvscom.c       optional uvscom ucom
 dev/usb/usb.c          optional usb
 dev/usb/usb_ethersubr.c        optional usb
-#dev/usb/usb_mem.c     optional usb
+dev/usb/usb_mem.c      optional usb
 dev/usb/usb_quirks.c   optional usb
 dev/usb/usb_subr.c     optional usb
 dev/usb/usbdi.c                optional usb
Index: dev/usb/usb_mem.h
===================================================================
RCS file: /home/ncvs/src/sys/dev/usb/usb_mem.h,v
retrieving revision 1.17
diff -u -r1.17 usb_mem.h
--- dev/usb/usb_mem.h   28 May 2002 20:51:43 -0000      1.17
+++ dev/usb/usb_mem.h   15 Jan 2003 19:12:39 -0000
@@ -38,7 +38,6 @@
  * POSSIBILITY OF SUCH DAMAGE.
  */
 
-#if defined(__NetBSD__) || defined(__OpenBSD__)
 typedef struct usb_dma_block {
        bus_dma_tag_t tag;
        bus_dmamap_t map;
@@ -57,35 +56,3 @@
 
 usbd_status    usb_allocmem(usbd_bus_handle,size_t,size_t, usb_dma_t *);
 void           usb_freemem(usbd_bus_handle, usb_dma_t *);
-
-#elif defined(__FreeBSD__)
-
-/* 
- * FreeBSD does not have special functions for dma memory, so let's keep it
- * simple for now.
- */
-
-#include <sys/param.h>
-#include <sys/systm.h>
-#include <sys/queue.h>
-#include <sys/proc.h>
-#include <sys/bio.h>
-#include <sys/buf.h>
-#include <sys/malloc.h>
-#include <sys/kernel.h>
-#include <vm/vm.h>
-#include <vm/pmap.h>
-
-#include <machine/pmap.h>       /* for vtophys */
-
-#define                usb_allocmem(t,s,a,p)   (*(p) = malloc(s, M_USB, M_NOWAIT), 
(*(p) == NULL? USBD_NOMEM: USBD_NORMAL_COMPLETION))
-#define                usb_freemem(t,p)        (free(*(p), M_USB))
-
-#ifdef __alpha__
-#define DMAADDR(dma, o)        (alpha_XXX_dmamap((vm_offset_t) *(dma) + (o)))
-#else
-#define DMAADDR(dma, o)        (vtophys(*(dma) + (o)))
-#endif
-#define KERNADDR(dma, o)       ((void *) ((char *)*(dma) + (o)))
-#endif /* __FreeBSD__ */
-
Index: dev/usb/usb_port.h
===================================================================
RCS file: /home/ncvs/src/sys/dev/usb/usb_port.h,v
retrieving revision 1.58
diff -u -r1.58 usb_port.h
--- dev/usb/usb_port.h  2 Oct 2002 07:44:20 -0000       1.58
+++ dev/usb/usb_port.h  15 Jan 2003 19:10:58 -0000
@@ -355,7 +355,12 @@
 #define USBDEVUNIT(bdev) device_get_unit(bdev)
 #define USBGETSOFTC(bdev) (device_get_softc(bdev))
 
-#define DECLARE_USB_DMA_T typedef char * usb_dma_t
+#define DECLARE_USB_DMA_T \
+       struct usb_dma_block; \
+       typedef struct { \
+               struct usb_dma_block *block; \
+               u_int offs; \
+       } usb_dma_t
 
 typedef struct thread *usb_proc_ptr;
 
Index: dev/usb/usbdivar.h
===================================================================
RCS file: /home/ncvs/src/sys/dev/usb/usbdivar.h,v
retrieving revision 1.37
diff -u -r1.37 usbdivar.h
--- dev/usb/usbdivar.h  7 Apr 2002 13:37:46 -0000       1.37
+++ dev/usb/usbdivar.h  15 Jan 2003 19:31:06 -0000
@@ -124,9 +124,7 @@
 #endif
 #endif
 
-#if defined(__NetBSD__) || defined(__OpenBSD__)
        bus_dma_tag_t           dmatag; /* DMA tag */
-#endif
 };
 
 struct usbd_device {
/*      $NetBSD: usb_mem.c,v 1.25 2002/12/30 02:44:32 dsainty Exp $     */

/*
 * Copyright (c) 1998 The NetBSD Foundation, Inc.
 * All rights reserved.
 *
 * This code is derived from software contributed to The NetBSD Foundation
 * by Lennart Augustsson ([EMAIL PROTECTED]) at
 * Carlstedt Research & Technology.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 * 1. Redistributions of source code must retain the above copyright
 *    notice, this list of conditions and the following disclaimer.
 * 2. Redistributions in binary form must reproduce the above copyright
 *    notice, this list of conditions and the following disclaimer in the
 *    documentation and/or other materials provided with the distribution.
 * 3. All advertising materials mentioning features or use of this software
 *    must display the following acknowledgement:
 *        This product includes software developed by the NetBSD
 *        Foundation, Inc. and its contributors.
 * 4. Neither the name of The NetBSD Foundation nor the names of its
 *    contributors may be used to endorse or promote products derived
 *    from this software without specific prior written permission.
 *
 * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
 * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
 * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
 * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
 * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
 * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
 * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
 * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 * POSSIBILITY OF SUCH DAMAGE.
 */

/*
 * USB DMA memory allocation.
 * We need to allocate a lot of small (many 8 byte, some larger)
 * memory blocks that can be used for DMA.  Using the bus_dma
 * routines directly would incur large overheads in space and time.
 */

#include <sys/cdefs.h>

#include <sys/param.h>
#include <sys/systm.h>
#include <sys/kernel.h>
#include <sys/malloc.h>
#include <sys/queue.h>
#include <machine/bus.h>

#ifdef DIAGNOSTIC
#include <sys/proc.h>
#endif

#include <dev/usb/usb.h>
#include <dev/usb/usbdi.h>
#include <dev/usb/usbdivar.h>   /* just for usb_dma_t */
#include <dev/usb/usb_mem.h>

#ifdef USB_DEBUG
#define DPRINTF(x)      if (usbdebug) logprintf x
#define DPRINTFN(n,x)   if (usbdebug>(n)) logprintf x
extern int usbdebug;
#else
#define DPRINTF(x)
#define DPRINTFN(n,x)
#endif

#define USB_MEM_SMALL 64
#define USB_MEM_CHUNKS 64
#define USB_MEM_BLOCK (USB_MEM_SMALL * USB_MEM_CHUNKS)

/* This struct is overlayed on free fragments. */
struct usb_frag_dma {
        usb_dma_block_t *block;
        u_int offs;
        LIST_ENTRY(usb_frag_dma) next;
};

Static usbd_status      usb_block_allocmem(bus_dma_tag_t, size_t, size_t,
                                           usb_dma_block_t **);
Static void             usb_block_freemem(usb_dma_block_t *);

Static LIST_HEAD(, usb_dma_block) usb_blk_freelist =
        LIST_HEAD_INITIALIZER(usb_blk_freelist);
Static int usb_blk_nfree = 0;
/* XXX should have different free list for different tags (for speed) */
Static LIST_HEAD(, usb_frag_dma) usb_frag_freelist =
        LIST_HEAD_INITIALIZER(usb_frag_freelist);

Static usbd_status
usb_block_allocmem(bus_dma_tag_t tag, size_t size, size_t align,
                   usb_dma_block_t **dmap)
{
        int error;
        usb_dma_block_t *p;
        int s;

        DPRINTFN(5, ("usb_block_allocmem: size=%lu align=%lu\n",
                     (u_long)size, (u_long)align));

#ifdef DIAGNOSTIC
        if (!curproc) {
                printf("usb_block_allocmem: in interrupt context, size=%lu\n",
                    (unsigned long) size);
        }
#endif

        s = splusb();
        /* First check the free list. */
        for (p = LIST_FIRST(&usb_blk_freelist); p; p = LIST_NEXT(p, next)) {
                if (p->tag == tag && p->size >= size && p->align >= align) {
                        LIST_REMOVE(p, next);
                        usb_blk_nfree--;
                        splx(s);
                        *dmap = p;
                        DPRINTFN(6,("usb_block_allocmem: free list size=%lu\n",
                                    (u_long)p->size));
                        return (USBD_NORMAL_COMPLETION);
                }
        }
        splx(s);

#ifdef DIAGNOSTIC
        if (!curproc) {
                printf("usb_block_allocmem: in interrupt context, failed\n");
                return (USBD_NOMEM);
        }
#endif

        DPRINTFN(6, ("usb_block_allocmem: no free\n"));
        p = malloc(sizeof *p, M_USB, M_NOWAIT);
        if (p == NULL)
                return (USBD_NOMEM);
        *dmap = p;

        p->tag = tag;
        p->size = size;
        p->align = align;
        error = bus_dmamem_alloc(tag, p->size, align, 0,
                                 p->segs, sizeof(p->segs)/sizeof(p->segs[0]),
                                 &p->nsegs, BUS_DMA_NOWAIT);
        if (error)
                return (USBD_NOMEM);

        error = bus_dmamem_map(tag, p->segs, p->nsegs, p->size,
                               &p->kaddr, BUS_DMA_NOWAIT|BUS_DMA_COHERENT);
        if (error)
                goto free;

        error = bus_dmamap_create(tag, p->size, 1, p->size,
                                  0, BUS_DMA_NOWAIT, &p->map);
        if (error)
                goto unmap;

        error = bus_dmamap_load(tag, p->map, p->kaddr, p->size, NULL,
                                BUS_DMA_NOWAIT);
        if (error)
                goto destroy;
        return (USBD_NORMAL_COMPLETION);

destroy:
        bus_dmamap_destroy(tag, p->map);
unmap:
        bus_dmamem_unmap(tag, p->kaddr, p->size);
free:
        bus_dmamem_free(tag, p->segs, p->nsegs);
        return (USBD_NOMEM);
}

#if 0
void
usb_block_real_freemem(usb_dma_block_t *p)
{
#ifdef DIAGNOSTIC
        if (!curproc) {
                printf("usb_block_real_freemem: in interrupt context\n");
                return;
        }
#endif
        bus_dmamap_unload(p->tag, p->map);
        bus_dmamap_destroy(p->tag, p->map);
        bus_dmamem_unmap(p->tag, p->kaddr, p->size);
        bus_dmamem_free(p->tag, p->segs, p->nsegs);
        free(p, M_USB);
}
#endif

/*
 * Do not free the memory unconditionally since we might be called
 * from an interrupt context and that is BAD.
 * XXX when should we really free?
 */
Static void
usb_block_freemem(usb_dma_block_t *p)
{
        int s;

        DPRINTFN(6, ("usb_block_freemem: size=%lu\n", (u_long)p->size));
        s = splusb();
        LIST_INSERT_HEAD(&usb_blk_freelist, p, next);
        usb_blk_nfree++;
        splx(s);
}

usbd_status
usb_allocmem(usbd_bus_handle bus, size_t size, size_t align, usb_dma_t *p)
{
        bus_dma_tag_t tag = bus->dmatag;
        usbd_status err;
        struct usb_frag_dma *f;
        usb_dma_block_t *b;
        int i;
        int s;

        /* If the request is large then just use a full block. */
        if (size > USB_MEM_SMALL || align > USB_MEM_SMALL) {
                DPRINTFN(1, ("usb_allocmem: large alloc %d\n", (int)size));
                size = (size + USB_MEM_BLOCK - 1) & ~(USB_MEM_BLOCK - 1);
                err = usb_block_allocmem(tag, size, align, &p->block);
                if (!err) {
                        p->block->fullblock = 1;
                        p->offs = 0;
                }
                return (err);
        }

        s = splusb();
        /* Check for free fragments. */
        for (f = LIST_FIRST(&usb_frag_freelist); f; f = LIST_NEXT(f, next))
                if (f->block->tag == tag)
                        break;
        if (f == NULL) {
                DPRINTFN(1, ("usb_allocmem: adding fragments\n"));
                err = usb_block_allocmem(tag, USB_MEM_BLOCK, USB_MEM_SMALL,&b);
                if (err) {
                        splx(s);
                        return (err);
                }
                b->fullblock = 0;
                for (i = 0; i < USB_MEM_BLOCK; i += USB_MEM_SMALL) {
                        f = (struct usb_frag_dma *)(b->kaddr + i);
                        f->block = b;
                        f->offs = i;
                        LIST_INSERT_HEAD(&usb_frag_freelist, f, next);
                }
                f = LIST_FIRST(&usb_frag_freelist);
        }
        p->block = f->block;
        p->offs = f->offs;
        LIST_REMOVE(f, next);
        splx(s);
        DPRINTFN(5, ("usb_allocmem: use frag=%p size=%d\n", f, (int)size));
        return (USBD_NORMAL_COMPLETION);
}

void
usb_freemem(usbd_bus_handle bus, usb_dma_t *p)
{
        struct usb_frag_dma *f;
        int s;

        if (p->block->fullblock) {
                DPRINTFN(1, ("usb_freemem: large free\n"));
                usb_block_freemem(p->block);
                return;
        }
        f = KERNADDR(p, 0);
        f->block = p->block;
        f->offs = p->offs;
        s = splusb();
        LIST_INSERT_HEAD(&usb_frag_freelist, f, next);
        splx(s);
        DPRINTFN(5, ("usb_freemem: frag=%p\n", f));
}

Attachment: msg50319/pgp00000.pgp
Description: PGP signature

Reply via email to