Nate Lawson wrote: > Attached is a diff that fixes a "could sleep" problem where > ether_ifattach() does a malloc and dc(4) is holding a lock in its softc. > It uses a cleaner exit strategy with only one call to DC_UNLOCK and no > multiple return statements as well as fixing one place where "error" > wasn't set. If people are ok with it, I'll sweep other drivers that have > a similar problem.
Doing this would maybe be a bit premature. A lot of drivers have FOO_LOCK and FOO_UNLOCK macros set to nothing, because of similar problems you're trying to fix. Interface locking probably needs to be rethought. Cheers, Maxime To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
