On Sat, Nov 02, 2002 at 08:04:21PM -0800, Kris Kennaway wrote:
> The latest bento run on 5.0 is the first to build without perl
> present: previously, two of the portbuild scripts were written in
> perl, so I had to always pkg_add it into the chroot environment. Now
> that these scripts have been rewritten in C and I have stopped doing
> the pkg_add, it is exposing all the ports that should have a
> dependency on perl but currently do not.
>
> At least 700 additional ports are breaking for this reason. Many of
> them are using ${PERL} to do patching-in-place, and these should be
> converted to use REINPLACE_CMD/USE_REINPLACE. Others use perl
> during the build and should set USE_PERL.
>
> Everyone please check
>
> http://bento.freebsd.org/errorlogs/5-latest/index-maintainer.html
>
> ASAP and fix the listed problems. Note that I am aware of two
> problems with the recent build:
>
> 1) Port builds are being killed after 1 hour, instead of after 1 hour
> *without output*. This is a bug in the aforementioned C code.
>
> 2) Ports that use PERL_CONFIGURE should automatically get a dependency
> on perl in bsd.port.mk. Apparently someone has submitted a patch for
> this already, but I don't immediately know where it is to test it.
It was me. I am attaching it with this message.
-Maxim
Index: bsd.port.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.426
diff -d -u -r1.426 bsd.port.mk
--- bsd.port.mk 2 Oct 2002 07:18:17 -0000 1.426
+++ bsd.port.mk 26 Oct 2002 13:13:21 -0000
@@ -1006,6 +1006,10 @@
PERL_VER=${PERL_VER} \
PERL_ARCH=${PERL_ARCH}
+.if defined(PERL_CONFIGURE)
+USE_PERL5= yes
+.endif
+
.if exists(/usr/bin/perl5) && ${OSVERSION} >= 300000 && ${OSVERSION} < 500036
.if !exists(/usr/bin/perl${PERL_VERSION}) && defined(USE_PERL5)
pre-everything::
@@ -1674,7 +1678,6 @@
CONFIGURE_ARGS+= CC="${CC}" CCFLAGS="${CFLAGS}" PREFIX="${PREFIX}" \
INSTALLPRIVLIB="${PREFIX}/lib" INSTALLARCHLIB="${PREFIX}/lib"
CONFIGURE_SCRIPT?= Makefile.PL
-USE_PERL5= yes
.undef HAS_CONFIGURE
.endif
