On Fri, 2002-07-19 at 07:42, Alexander Kabaev wrote:
> On 19 Jul 2002 07:33:30 -0500
> Rob Hughes <[EMAIL PROTECTED]> wrote:
> 
> > can't fetch resources for \\_SB_.LNKA - AE_BAD_DATA
> >  can't fetch resources for \\_SB_.LNKB - AE_BAD_DATA
> >  can't fetch resources for \\_SB_.LNKC - AE_BAD_DATA
> >  can't fetch resources for \\_SB_.LNKF - AE_BAD_DATA
> >  can't fetch resources for \\_SB_.LNKH - AE_BAD_DATA
> >  can't fetch resources for \\_SB_.PCI0.FNC0.FSIR - AE_BAD_DATA
> 
> ^^^^^^^ I had to patch ACPICA sources to make my laptoop to work.
> Apparently, folks at ACPI mailing list made exactly the same patch too.
> Returning AE_BAD_DATA for empty resource descriptors is wrong.
> 
> Index: rsio.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/contrib/dev/acpica/rsio.c,v
> retrieving revision 1.1.1.7
> diff -u -r1.1.1.7 rsio.c
> --- rsio.c    9 Jul 2002 17:51:30 -0000       1.1.1.7
> +++ rsio.c    14 Jul 2002 04:02:15 -0000
> @@ -501,12 +501,14 @@
>              i++;
>          }
>      }
> +#if 0
>      if (i == 0)
>      {
>          /* Zero channels is invalid! */
>  
>          return_ACPI_STATUS (AE_BAD_DATA);
>      }
> +#endif
>      OutputStruct->Data.Dma.NumberOfChannels = i;
>  
>  
> Index: rsirq.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/contrib/dev/acpica/rsirq.c,v
> retrieving revision 1.1.1.9
> diff -u -r1.1.1.9 rsirq.c
> --- rsirq.c   9 Jul 2002 17:51:30 -0000       1.1.1.9
> +++ rsirq.c   14 Jul 2002 03:30:02 -0000
> @@ -190,12 +190,14 @@
>          }
>      }
>  
> +#if 0
>      if (i == 0)
>      {
>          /* Zero interrupts is invalid! */
>  
>          return_ACPI_STATUS (AE_BAD_DATA);
>      }
> +#endif
>      OutputStruct->Data.Irq.NumberOfInterrupts = i;
>  
>      /*
> -- 
> Alexander Kabaev
> 

Thanks! I'll give this a shot when I get home tonight. Gotta get to the
customer site right now, though.

Rob


-- 
Remember: the only difference between
being the champ and the chump is u.

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to