On 18-Jul-2002 Matthew Dillon wrote: > >: >:* Matthew Dillon <[EMAIL PROTECTED]> [020718 11:40] wrote: >:> >:> fdalloc() does not reserve the descriptor number it >:> returns, it simply finds a free slot and says 'this >:> index is a free slot'. Even in the latest -current, >:> fdalloc() releases the fdp lock when it goes to >:> MALLOC so the race appears to still be present. >: >:This is true. I think one way to fix this is to preallocate >:the 'struct file' you're going to put into the array and have >:fdalloc() insert the created file instead of just finding a >:slot. Problem is that it's a bunch of grunt work to do this. >: >:-- >:-Alfred Perlstein [[EMAIL PROTECTED]] >:'Instead of asking why a piece of software is using "1970s technology," > > If you do this be careful in regards to open() and close() which > might place the descriptor in a transitory state. You don't want > another thread picking the descriptor up while it is in that > state.
If you really wanted to do this you could just use '(struct file *)1' or some other evil, but I really don't think it's necessary. -- John Baldwin <[EMAIL PROTECTED]> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
