* Alfred Perlstein <[EMAIL PROTECTED]> [010712 01:45] wrote:
> * Alfred Perlstein <[EMAIL PROTECTED]> [010712 01:42] wrote:
> > * Seigo Tanimura <[EMAIL PROTECTED]> [010711 19:08] wrote:
> > > 
> > > The patch and the results of build test are now on the web page.
> > > 
> > > The discussion of ktrace(2) problem does not cover the solution of
> > > BSD/OS, so it needs updating.
> > 
> > I'm just reviewing the file stuff, I have a number of updates mainly
> > in the areas of needing FFIND_HOLD/fdrop rather than just a simple
> > FFIND.
> > 
> > getvnode(p->p_fd, args->fd, &fp);
> > 
> > I'm quite sure should implicitly do a FHOLD operation on the returned
> > struct file, i don't see this, at least not in linux_getdents()
> > (compat/linux/linux_file.c).
> 
> Or at least an fhold needs to be done before relasing the lock
> on the struct file.

Furthermore, all the fo_* functions should not be calling FHOLD
themselves, the fhold needs to have been done by whomever calls
them to make sure that the 'fp' doesn't disapear out from under
the fo_ function.

-- 
-Alfred Perlstein [[EMAIL PROTECTED]]
Ok, who wrote this damn function called '??'?
And why do my programs keep crashing in it?

To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Reply via email to