Dag-Erling Smørgrav <[email protected]> wrote: > > > Do I need to set > > > WITHOUT_DEPEND_CLEANUP= to have META_MODE= work as it used to? > > My guess would be yes. > > That's not a guess, that's a knee-jerk reaction to something new that > you don't understand and didn't bother to research.
Its a polite way of saying "I think so". I did actually look at your patch, and do a buildworld to see what is being recorded before stating the above. AFAICT MK_DEPEND_CLEANUP=yes tracks and compares the values of all the known options (sans those known to be not relevant) and if any change, is supposed to trigger a clean of the tree. What did I miss? If my assessment of the behavior is correct, I'd argue it is unnecessary if MK_META_MODE=yes, and infact counter productive. As I noted, there are cases where you still might want to do a tree clean if using META_MODE, but changing option values shouldn't be one of them. --sjg
