On 4/14/23 07:40, Pawel Jakub Dawidek wrote:
On 4/13/23 22:56, Cy Schubert wrote:
I'm in the process of building a branch reverting the merge altogether
and
will test it on my sandbox machine later today.
Cy,
thank you for your testing and patience so far. I'm working on a patch
to revert block cloning without affecting people who already upgraded
their pools.
I'd also greatly appreciate if you could provide a procedure for me to
reproduce the corruption, ideally without the internet access, as I'll
be on the plane(s) for the next ~24h.
Here is the change that reverts most of the modifications and disables
cloning new blocks. It does retain ability to free existing cloned
blocks and keeps block_cloning feature around, so upgraded pools can be
imported and existing cloned blocks freed.
It does not handle replaying ZIL with block-cloning logs, so make sure
you import pools that were cleanly exported.
I'd appreciate if someone who can reproduce those corruptions could try it.
https://github.com/pjd/openzfs/commit/f2cfbcf76a733c44e25cba8c649162ef68047103
Thank you guys for your help!
--
Pawel Jakub Dawidek
