> On 1 Oct 2022, at 22:57, Larry Rosenman <l...@lerctr.org> wrote:
>
> --- all_subdir_nfscommon ---
> Building
> /usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/nfscommon/nfs_commonkrpc.o
> --- all_subdir_netgraph ---
> --- all_subdir_netgraph/deflate ---
> Building
> /usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/netgraph/deflate/offset.inc
> --- all_subdir_netgraph/device ---
> Building
> /usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/netgraph/device/i386
> --- all_subdir_netgraph/echo ---
> ===> netgraph/echo (all)
> --- all_subdir_netlink ---
> --- netlink_io.o ---
> /usr/src/sys/netlink/netlink_io.c:146:2: error: implicit declaration of
> function 'mtx_lock' is invalid in C99
> [-Werror,-Wimplicit-function-declaration]
> NLP_LOCK(nlp);
That’s interesting. netlink_io.c includes sys/mutex.h which defines
mutex_lock() / mutex_unlock().
Could you share the diff between GENERIC and LER-MINIMAL?
> ^
> /usr/src/sys/netlink/netlink_var.h:79:25: note: expanded from macro 'NLP_LOCK'
> #define NLP_LOCK(_nlp) mtx_lock(&((_nlp)->nl_lock))
> ^
> /usr/src/sys/netlink/netlink_io.c:159:2: error: implicit declaration of
> function 'mtx_unlock' is invalid in C99
> [-Werror,-Wimplicit-function-declaration]
> NLP_UNLOCK(nlp);
> ^
> /usr/src/sys/netlink/netlink_var.h:80:26: note: expanded from macro
> 'NLP_UNLOCK'
> #define NLP_UNLOCK(_nlp) mtx_unlock(&((_nlp)->nl_lock))
> ^
> /usr/src/sys/netlink/netlink_io.c:159:2: note: did you mean 'mtx_lock'?
> /usr/src/sys/netlink/netlink_var.h:80:26: note: expanded from macro
> 'NLP_UNLOCK'
> #define NLP_UNLOCK(_nlp) mtx_unlock(&((_nlp)->nl_lock))
> ^
> /usr/src/sys/netlink/netlink_io.c:146:2: note: 'mtx_lock' declared here
> NLP_LOCK(nlp);
> ^
> /usr/src/sys/netlink/netlink_var.h:79:25: note: expanded from macro 'NLP_LOCK'
> #define NLP_LOCK(_nlp) mtx_lock(&((_nlp)->nl_lock))
> ^
> /usr/src/sys/netlink/netlink_io.c:177:2: error: implicit declaration of
> function 'mtx_lock' is invalid in C99
> [-Werror,-Wimplicit-function-declaration]
> SOCKBUF_LOCK(sb);
> ^
> /usr/src/sys/sys/sockbuf.h:187:28: note: expanded from macro 'SOCKBUF_LOCK'
> #define SOCKBUF_LOCK(_sb) mtx_lock(SOCKBUF_MTX(_sb))
> ^
> /usr/src/sys/netlink/netlink_io.c:189:2: error: implicit declaration of
> function 'mtx_unlock' is invalid in C99
> [-Werror,-Wimplicit-function-declaration]
> SOCKBUF_UNLOCK(sb);
> ^
> /usr/src/sys/sys/sockbuf.h:189:30: note: expanded from macro 'SOCKBUF_UNLOCK'
> #define SOCKBUF_UNLOCK(_sb) mtx_unlock(SOCKBUF_MTX(_sb))
> ^
> /usr/src/sys/netlink/netlink_io.c:202:2: error: implicit declaration of
> function 'mtx_lock' is invalid in C99
> [-Werror,-Wimplicit-function-declaration]
> NLP_LOCK(nlp);
> ^
> /usr/src/sys/netlink/netlink_var.h:79:25: note: expanded from macro 'NLP_LOCK'
> #define NLP_LOCK(_nlp) mtx_lock(&((_nlp)->nl_lock))
> ^
> /usr/src/sys/netlink/netlink_io.c:207:3: error: implicit declaration of
> function 'mtx_unlock' is invalid in C99
> [-Werror,-Wimplicit-function-declaration]
> NLP_UNLOCK(nlp);
> ^
> /usr/src/sys/netlink/netlink_var.h:80:26: note: expanded from macro
> 'NLP_UNLOCK'
> #define NLP_UNLOCK(_nlp) mtx_unlock(&((_nlp)->nl_lock))
> ^
> /usr/src/sys/netlink/netlink_io.c:225:3: error: implicit declaration of
> function 'mtx_unlock' is invalid in C99
> [-Werror,-Wimplicit-function-declaration]
> SOCKBUF_UNLOCK(sb);
> ^
> /usr/src/sys/sys/sockbuf.h:189:30: note: expanded from macro 'SOCKBUF_UNLOCK'
> #define SOCKBUF_UNLOCK(_sb) mtx_unlock(SOCKBUF_MTX(_sb))
> ^
> /usr/src/sys/netlink/netlink_io.c:232:2: error: implicit declaration of
> function 'mtx_unlock' is invalid in C99
> [-Werror,-Wimplicit-function-declaration]
> NLP_UNLOCK(nlp);
> ^
> /usr/src/sys/netlink/netlink_var.h:80:26: note: expanded from macro
> 'NLP_UNLOCK'
> #define NLP_UNLOCK(_nlp) mtx_unlock(&((_nlp)->nl_lock))
> ^
> /usr/src/sys/netlink/netlink_io.c:281:2: error: implicit declaration of
> function 'mtx_lock' is invalid in C99
> [-Werror,-Wimplicit-function-declaration]
> NLP_LOCK(nlp);
> ^
> /usr/src/sys/netlink/netlink_var.h:79:25: note: expanded from macro 'NLP_LOCK'
> #define NLP_LOCK(_nlp) mtx_lock(&((_nlp)->nl_lock))
> ^
> /usr/src/sys/netlink/netlink_io.c:299:2: error: implicit declaration of
> function 'mtx_unlock' is invalid in C99
> [-Werror,-Wimplicit-function-declaration]
> NLP_UNLOCK(nlp);
> ^
> /usr/src/sys/netlink/netlink_var.h:80:26: note: expanded from macro
> 'NLP_UNLOCK'
> #define NLP_UNLOCK(_nlp) mtx_unlock(&((_nlp)->nl_lock))
> ^
> /usr/src/sys/netlink/netlink_io.c:354:2: error: implicit declaration of
> function 'mtx_lock' is invalid in C99
> [-Werror,-Wimplicit-function-declaration]
> NLP_LOCK(nlp);
> ^
> /usr/src/sys/netlink/netlink_var.h:79:25: note: expanded from macro 'NLP_LOCK'
> #define NLP_LOCK(_nlp) mtx_lock(&((_nlp)->nl_lock))
> ^
> /usr/src/sys/netlink/netlink_io.c:357:3: error: implicit declaration of
> function 'mtx_unlock' is invalid in C99
> [-Werror,-Wimplicit-function-declaration]
> NLP_UNLOCK(nlp);
> ^
> /usr/src/sys/netlink/netlink_var.h:80:26: note: expanded from macro
> 'NLP_UNLOCK'
> #define NLP_UNLOCK(_nlp) mtx_unlock(&((_nlp)->nl_lock))
> ^
> /usr/src/sys/netlink/netlink_io.c:369:3: error: implicit declaration of
> function 'mtx_unlock' is invalid in C99
> [-Werror,-Wimplicit-function-declaration]
> NLP_UNLOCK(nlp);
> ^
> /usr/src/sys/netlink/netlink_var.h:80:26: note: expanded from macro
> 'NLP_UNLOCK'
> #define NLP_UNLOCK(_nlp) mtx_unlock(&((_nlp)->nl_lock))
> ^
> /usr/src/sys/netlink/netlink_io.c:395:2: error: implicit declaration of
> function 'mtx_unlock' is invalid in C99
> [-Werror,-Wimplicit-function-declaration]
> NLP_UNLOCK(nlp);
> ^
> /usr/src/sys/netlink/netlink_var.h:80:26: note: expanded from macro
> 'NLP_UNLOCK'
> #define NLP_UNLOCK(_nlp) mtx_unlock(&((_nlp)->nl_lock))
> ^
> /usr/src/sys/netlink/netlink_io.c:519:3: error: implicit declaration of
> function 'mtx_lock' is invalid in C99
> [-Werror,-Wimplicit-function-declaration]
> NLP_LOCK(nlp);
> ^
> /usr/src/sys/netlink/netlink_var.h:79:25: note: expanded from macro 'NLP_LOCK'
> #define NLP_LOCK(_nlp) mtx_lock(&((_nlp)->nl_lock))
> ^
> /usr/src/sys/netlink/netlink_io.c:521:3: error: implicit declaration of
> function 'mtx_unlock' is invalid in C99
> [-Werror,-Wimplicit-function-declaration]
> NLP_UNLOCK(nlp);
> ^
> /usr/src/sys/netlink/netlink_var.h:80:26: note: expanded from macro
> 'NLP_UNLOCK'
> #define NLP_UNLOCK(_nlp) mtx_unlock(&((_nlp)->nl_lock))
> ^
> 16 errors generated.
> --- all_subdir_netgraph ---
> --- all_subdir_netgraph/device ---
> --- i386 ---
> i386 -> /usr/src/sys/i386/include
> Building
> /usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/netgraph/device/vnode_if_newproto.h
> --- all_subdir_netlink ---
> *** [netlink_io.o] Error code 1
>
> make[4]: stopped in /usr/src/sys/modules/netlink
> .ERROR_TARGET='netlink_io.o'
> .ERROR_META_FILE='/usr/obj/usr/src/amd64.amd64/sys/LER-MINIMAL/modules/usr/src/sys/modules/netlink/netlink_io.o.meta'
> .MAKE.LEVEL='4'
> MAKEFILE=''
> .MAKE.MODE='meta missing-filemon=yes missing-meta=yes silent=yes verbose'
> 5.79 real 30.04 user 9.35 sys
>
> make[1]: stopped in /usr/src
>
> make: stopped in /usr/src
>
> ler in 🌐 borg in src🔒 on ler/freebsd-main-changes:main [⇡] on ☁️
> (us-east-1) took 1m56s
> ❯
>
> ler in 🌐 borg in src🔒 on ler/freebsd-main-changes:main [⇡] on ☁️
> (us-east-1)
> ❯
>
>
>
> --
> Larry Rosenman http://www.lerctr.org/~ler
> Phone: +1 214-642-9640 E-Mail: l...@lerctr.org
> US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106
>
