The prior version (r355814) works just fine, if you wanted to get going... Sorry for the hassle.. I'm flushing my WIP trees, deleting old stuff and forgot this change had a dependency on something that's not quite ready yet.
Warner On Mon, Dec 16, 2019 at 4:12 PM pete wright <nomadlo...@gmail.com> wrote: > Thanks, maybe git mirror was lagging will test in a bit. > > Thanks! > -pete > > On Mon, Dec 16, 2019, 3:09 PM Warner Losh <i...@bsdimp.com> wrote: > >> Update. That version was in place for about an hour before I fixed it. >> r355815 broke it and r355818 fixed it. >> >> Warner >> >> >> On Mon, Dec 16, 2019 at 3:27 PM pete wright <nomadlo...@gmail.com> wrote: >> >>> here's the error i'm getting when building: >>> /usr/home/pete/git/freebsd/sys/cam/scsi/scsi_da.c:1544:28: error: >>> expected >>> identifier >>> SYSCTL_INT64(_kern_cam_da, OID_AUTO, default_max_delete, CTLFLAG_RWTUN, >>> ^ >>> /usr/home/pete/git/freebsd/sys/sys/sysctl.h:126:18: note: expanded from >>> macro 'OID_AUTO' >>> #define OID_AUTO (-1) >>> ^ >>> /usr/home/pete/git/freebsd/sys/cam/scsi/scsi_da.c:1544:1: error: type >>> specifier missing, defaults to 'int' [-Werror,-Wimplicit-int] >>> SYSCTL_INT64(_kern_cam_da, OID_AUTO, default_max_delete, CTLFLAG_RWTUN, >>> ^ >>> /usr/home/pete/git/freebsd/sys/cam/scsi/scsi_da.c:1544:13: error: this >>> function declaration is not a prototype [-Werror,-Wstrict-prototypes] >>> SYSCTL_INT64(_kern_cam_da, OID_AUTO, default_max_delete, CTLFLAG_RWTUN, >>> ^ >>> 3 errors generated. >>> *** [scsi_da.o] Error code 1 >>> >>> >>> >>> might be this commit? >>> commit 5fa79c6768be78d78815156f8ecf50cb2008233f (HEAD -> master, >>> origin/master, origin/HEAD) >>> Author: imp <i...@freebsd.org> <i...@freebsd.org> >>> Date: Mon Dec 16 18:16:44 2019 +0000 >>> >>> Implement a system-wide limit or da and ada devices for delete. >>> >>> Excesively large TRIMs can result in timeouts, which cause big >>> problems. Limit trims to 1GB to mititgate these issues. >>> >>> Reviewed by: scottl >>> Differential Revision: https://reviews.freebsd.org/D22809 >>> >>> >>> >>> if there is any additional info needed happy to provide it. >>> >>> cheers, >>> -pete >>> >>> -- >>> pete wright >>> www.nomadlogic.org >>> @nomadlogicLA >>> _______________________________________________ >>> freebsd-current@freebsd.org mailing list >>> https://lists.freebsd.org/mailman/listinfo/freebsd-current >>> To unsubscribe, send any mail to " >>> freebsd-current-unsubscr...@freebsd.org" >>> >> _______________________________________________ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
