Am Fri, 30 Dec 2016 21:40:27 +0200 Toomas Soome <tso...@me.com> schrieb:
> > On 30. dets 2016, at 21:35, Dimitry Andric <d...@freebsd.org> wrote: > > > > On 30 Dec 2016, at 20:23, O. Hartmann <ohartm...@walstatt.org> wrote: > >> > >> Recent update of CURRENT to 2310850 fails with buildworld error: > >> > >> [...] > >> ===> lib/atf/libatf-c++ (all) > >> --- all_subdir_lib/libstand --- > >> --- nandfs.o --- > >> /usr/src/lib/libstand/nandfs.c:1049:15: error: too many arguments to > >> function call, > >> expected 6, have 7 buffer, NULL); > >> ^~~~ > >> /usr/obj/usr/src/tmp/usr/include/sys/_null.h:32:14: note: expanded from > >> macro 'NULL' > >> #define NULL ((void *)0) > >> ^~~~~~~~~~~ > >> 1 error generated. > >> *** [nandfs.o] Error code 1 > > > > This looks like the culprit to me: > > > > On 30 Dec 2016, at 20:06, Toomas Soome <tso...@freebsd.org> wrote: > >> Author: tsoome > >> Date: Fri Dec 30 19:06:29 2016 > >> New Revision: 310850 > >> URL: https://svnweb.freebsd.org/changeset/base/310850 > >> > >> Log: > >> dosfs support in libstand is broken since r298230 > >> > >> Apparently the libstand dosfs optimization is a bit too optimistic > >> and did introduce possible memory corruption. > >> > >> This patch is backing out the bad part and since this results in > >> dosfs reading full blocks now, we can also remove extra offset argument > >> from dv_strategy callback. > >> > >> The analysis of the issue and the backout patch is provided by Mikhail > >> Kupchik. > >> > >> PR: 214423 > >> Submitted by: Mikhail Kupchik > >> Reported by: Mikhail Kupchik > >> Reviewed by: bapt, allanjude > >> Approved by: allanjude (mentor) > >> MFC after: 1 month > >> Differential Revision: https://reviews.freebsd.org/D864 > > > > For some reason, your build seems to pick up an older stand.h header? > > > > -Dimitry > > > > > oh, apparently I *still* did miss one strategy call in nandfs.. Sorry, I’ll > try to fix > it asap. > > rgds, > toomas That has been fixed, thanks. But another bug in CARP makes buildkernel failing ... -- O. Hartmann Ich widerspreche der Nutzung oder Übermittlung meiner Daten für Werbezwecke oder für die Markt- oder Meinungsforschung (§ 28 Abs. 4 BDSG).
pgp4wBjZtTJr5.pgp
Description: OpenPGP digital signature
