On Feb 21, 2015, at 15:38, Garrett Cooper <yaneurab...@gmail.com> wrote:
> On Feb 21, 2015, at 15:35, James Gritton <ja...@freebsd.org> wrote: > >> On 2015-02-21 16:23, Garrett Cooper wrote: >>> On Feb 21, 2015, at 9:32, jenkins-ad...@freebsd.org wrote: >>>> See <https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests2/740/> >>> Jamie, >>> For some odd reason the last couple of commits you did to jail(8) >>> rocked the boat again with the pgrep/pkill -j testcases. I’ll look into >>> making them work again, but could you please send patches out to CR so I >>> can look at them and test them first. I hate the slew of Jenkins failures >>> emails and I’m sure there are others who feel the same. >>> Thanks! >> >> I'm as much at a loss as I was before, on how the changes I made could have >> any impact at all. The two recent commits to jls(8) (didn't touch jail(8)) >> only matter if you use jls's -v or -s options, neither of which is used in >> the pkill test case. >> >> As with the previous cycle of failures regarding jail(8), the problems >> appears not to be the changes I made, but that mere fact that something was >> committed to those programs. >> >> - Jamie > > Not disguising stderr, here’s what pops up: > > $ sudo prove -v pgrep-j_test.sh > pgrep-j_test.sh .. > 1..3 > jls: unknown parameter: allow > jls: unknown parameter: allow > jls: unknown parameter: allow > jls: unknown parameter: allow > jls: unknown parameter: allow > jls: unknown parameter: allow > jls: unknown parameter: allow > jls: unknown parameter: allow > jls: unknown parameter: allow > jls: unknown parameter: allow > jls: unknown parameter: allow > jls: unknown parameter: allow > jls: unknown parameter: allow > jls: unknown parameter: allow > jls: unknown parameter: allow > jls: unknown parameter: allow > jls: unknown parameter: allow > jls: unknown parameter: allow > jls: unknown parameter: allow > jls: unknown parameter: allow > usage: pgrep [-LSfilnoqvx] [-d delim] [-F pidfile] [-G gid] [-M core] [-N > system] > [-P ppid] [-U uid] [-c class] [-g pgrp] [-j jid] > [-s sid] [-t tty] [-u euid] pattern ... > not ok 1 - pgrep -j <jid> # pgrep output: '', pidfile output: '3704 3706' > ok 2 - pgrep -j any You broke parsing dotted parameters in r279083. Thanks,
signature.asc
Description: Message signed with OpenPGP using GPGMail
