:Content-Type: text/plain; charset=us-ascii
:
:Matthew Dillon ([EMAIL PROTECTED]) wrote:
:> swap-SPL:
:>
:> Required splvm()'s had to be added to two places in the swap subsystem
:> (but I don't think the lack of these spl's is the cause of the
:> recently reported crashes, though it is possible).
:
:There are a few more that I still get if I dont add spl protection.
:I need to commit the SPLASSERT stuff but I'm scared about how badly it
:will break for people that run with INVARIANTS.
:
:I'll attach the whole SPLASSERT to the VM here.
:
:Also, I went through vfs_bio.c and added SPLASSERT there and it
:goes kaboom really quick. bdwrite calls everything with no spl
:proctection when it really should. My full SPLASSERT patch is at
:http://people.freebsd.org/~ps/splassert.diff. I should just go ahead and
:submit this. This patch doesn't have any of the vm patches we discussed
:last month.
Lets do this one step at a time. Let me get in my (relatively minor)
spl fixes, then I'll take a look at your vfs_bio.c stuff -- there's got
to be some cockpit trouble there because for the most part vfs_bio.c
does *NOT* need to run at splbio(). Only the buffer queue adds and drops
and hash table ops need to run at splbio(). Once you have a buffer in
hand and locked you own it.
-Matt
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
