W dniu 2010-11-19 22:23, freebsd-current-requ...@freebsd.org pisze:
Send freebsd-current mailing list submissions to
freebsd-current@freebsd.org
To subscribe or unsubscribe via the World Wide Web, visit
http://lists.freebsd.org/mailman/listinfo/freebsd-current
or, via email, send a message with subject or body 'help' to
freebsd-current-requ...@freebsd.org
You can reach the person managing the list at
freebsd-current-ow...@freebsd.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of freebsd-current digest..."
Today's Topics:
1. Re: old references to vfs_mountroot_try() (Alexander Best)
2. Re: Testing /dev/fido ? (Ivan Voras)
3. Re: TTY task group scheduling (Andriy Gapon)
4. Re: TTY task group scheduling (Eric Masson)
5. Re: TTY task group scheduling (Vincent Hoffman)
6. Re: aperf/mperf (Andriy Gapon)
7. Re: aperf/mperf (Daniel Nebdal)
8. Re: TTY task group scheduling (Jeremy Chadwick)
9. Re: www/chromium crashing whole system (Alexander Best)
10. new cpuid bits (Andriy Gapon)
11. A big-ish machine, cannot boot (Ivan Voras)
12. Re: aperf/mperf (Andriy Gapon)
13. Re: TTY task group scheduling (Taku YAMAMOTO)
14. Re: A big-ish machine, cannot boot (Andriy Gapon)
15. Re: A big-ish machine, cannot boot (Gary Jennejohn)
16. Re: taskqueue_create() name parameter lieftime (Andriy Gapon)
17. Re: new cpuid bits (Gary Jennejohn)
18. Re: A big-ish machine, cannot boot (Ivan Voras)
19. Re: A big-ish machine, cannot boot (Ivan Voras)
20. Re: A big-ish machine, cannot boot (Andriy Gapon)
21. Re: A big-ish machine, cannot boot (Garrett Cooper)
22. Re: A big-ish machine, cannot boot (Ivan Voras)
23. Re: A big-ish machine, cannot boot (Ivan Voras)
24. Re: old references to vfs_mountroot_try() (Marcel Moolenaar)
25. Re: [RFC] ifconfig description support in rc.d (Garrett Cooper)
26. Re: A big-ish machine, cannot boot (James R. Van Artsdalen)
27. Re: taskqueue_create() name parameter lieftime (John Baldwin)
28. Re: A big-ish machine, cannot boot (Andriy Gapon)
29. Re: A big-ish machine, cannot boot (Jung-uk Kim)
30. Re: A big-ish machine, cannot boot (Sean Bruno)
31. Re: [Call for Tests] PAT issue on Apple hardware (Jung-uk Kim)
32. Re: aperf/mperf (Nate Lawson)
33. Re: A big-ish machine, cannot boot (Antony Mawer)
34. Re: A big-ish machine, cannot boot (Chuck Swiger)
35. Re: www/chromium crashing whole system (Oliver Pinter)
----------------------------------------------------------------------
Message: 1
Date: Fri, 19 Nov 2010 12:40:55 +0000
From: Alexander Best<arun...@freebsd.org>
Subject: Re: old references to vfs_mountroot_try()
To: Sergey Kandaurov<pluk...@gmail.com>
Cc: freebsd-current@freebsd.org
Message-ID:<20101119124055.ga11...@freebsd.org>
Content-Type: text/plain; charset=us-ascii
On Fri Nov 19 10, Sergey Kandaurov wrote:
On 19 November 2010 02:14, Alexander Best<arun...@freebsd.org> wrote:
hi there,
vfs_mountroot_try() seems to have been removed, yet the src still contains
three references to it:
vfs_mount.c:386
vfs_mount.c:723
freebsd32_misc.c:2368
So, what about just to rename those comments to reflect function name change?
that looks fine. i don't know anything about vfs, so i simply figured out that
the reference to vfs_mountroot_try() was not right anymore, but couldn't find
where MNT_ROOTFS is now being set.
...so its parse_mount(). :)
could you commit that?
cheers.
alex
Index: sys/kern/vfs_mount.c
===================================================================
--- sys/kern/vfs_mount.c (revision 215516)
+++ sys/kern/vfs_mount.c (working copy)
@@ -383,7 +383,7 @@
* Filter out MNT_ROOTFS. We do not want clients of nmount() in
* userspace to set this flag, but we must filter it out if we want
* MNT_UPDATE on the root file system to work.
- * MNT_ROOTFS should only be set in the kernel in vfs_mountroot_try().
+ * MNT_ROOTFS should only be set in the kernel in parse_mount().
*/
uap->flags&= ~MNT_ROOTFS;
@@ -720,7 +720,7 @@
* Filter out MNT_ROOTFS. We do not want clients of mount() in
* userspace to set this flag, but we must filter it out if we want
* MNT_UPDATE on the root file system to work.
- * MNT_ROOTFS should only be set in the kernel in vfs_mountroot_try().
+ * MNT_ROOTFS should only be set in the kernel in parse_mount().
*/
uap->flags&= ~MNT_ROOTFS;
Index: sys/compat/freebsd32/freebsd32_misc.c
===================================================================
--- sys/compat/freebsd32/freebsd32_misc.c (revision 215516)
+++ sys/compat/freebsd32/freebsd32_misc.c (working copy)
@@ -2365,7 +2365,7 @@
* Filter out MNT_ROOTFS. We do not want clients of nmount() in
* userspace to set this flag, but we must filter it out if we want
* MNT_UPDATE on the root file system to work.
- * MNT_ROOTFS should only be set in the kernel in vfs_mountroot_try().
+ * MNT_ROOTFS should only be set in the kernel in parse_mount().
*/
uap->flags&= ~MNT_ROOTFS;
--
wbr,
pluknet
mam impreze w warszawie
do poniedziałku :)
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
