On 20.10.2010 2:33, Marcel Moolenaar wrote: >> What about the attached patch? I'm going to give it a swirl soon. The >> difference is that it tests whether dev begins with /dev/. > > Interesting. I've been thinking about this too, but isn't > exactly fool-proof. When devfs is the root file system, > you can use "ufs:da0s1a" to refer to the device special > file. It seems inconsistent to have "ufs:da0s1" fail when > ufs:/dev/da0s1" works (a real scenario with USB based mass > storage devices -- root mount is unheld as soon as umass > is created, but before daX exists for it). > > This patch at least covers the problem cases with a single > strstr(), and we may get away with the inconsistency given > above by documenting it properly. > > Andrey: any thoughts?
Currently usage information in parse_dir_ask() says that device should be specified with "/dev/". But conf0 does not use "/dev/". Also, Marcel, do you have any plans write some documentation with examples about using of new features? -- WBR, Andrey V. Elsukov
signature.asc
Description: OpenPGP digital signature
