On Thu, Dec 09, 1999 at 04:03:58PM +0100, Soren Schmidt wrote:
> It seems Greg Lehey wrote:
> > > OK, you asked for it, following is a patch to support the
> > > sis 5591 chipset. Remember this is done blindfolded, I
> > > have no HW to test on, but you guys do :)
> > >
> > > Let me know what happens...
> >
> > OK. Let's defer removing wd until we know that ata DMA works on these
> > platforms. We'll have a lot of unhappy customers otherwise, myself
> > (wearing another hat) included. If nobody else gets there first, I'll
> > look at this next week.
>
> It already being tested, and it works, but at the same tike I found
> out that the code in the old driver for the sis is schizofrenic, it
> has one way of setting things up, and another way of reporting how
> it is set :(, that way it is difficult to compare results from
> the two drivers..
I think the old wd code was broken on reporting. The reporting
was changed from the original submission, when it was committed.
See the attached message:
>From [EMAIL PROTECTED] Thu May 6 15:14:56 1999
Date: Thu, 6 May 1999 15:14:56 -0500
From: "Richard Seaman, Jr." <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Subject: Buglet in SiS support in ide_pci.c
Message-ID: <[EMAIL PROTECTED]>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary=tKW2IUtsqtDRztdT
X-Mailer: Mutt 0.95.4i
Status: RO
Content-Length: 1468
Lines: 44
--tKW2IUtsqtDRztdT
Content-Type: text/plain; charset=us-ascii
I was just installing a new drive on the machine with the
SiS 5591 chipset, and noticed strange results on the
verbose status probes.
It appears to me that the UDMA status register reported
somehow got flipped. It appears to only affect the
status report in verbose mode, and not the actual setting
of the controller.
If you would like me to commit this fix, let me know.
--
Richard Seaman, Jr. email: [EMAIL PROTECTED]
5182 N. Maple Lane phone: 414-367-5450
Chenequa WI 53058 fax: 414-367-5852
--tKW2IUtsqtDRztdT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="ide_pci.c.diff"
Index: sys/pci/ide_pci.c
===================================================================
RCS file: /home/ncvs/src/sys/pci/ide_pci.c,v
retrieving revision 1.33
diff -u -r1.33 ide_pci.c
--- ide_pci.c 1999/04/24 20:13:58 1.33
+++ ide_pci.c 1999/05/06 18:36:30
@@ -1161,8 +1161,8 @@
printf ("SiS 5591 status: %s drive %d Ultra DMA %s",
unitno < 2 ? "primary" : "secondary",
unitno & 1,
- (DATC & 0x80) ? "disabled\n" : "enabled");
- if ((DATC & 0x80) == 0)
+ (DATC & 0x80) ? "enabled" : "disabled\n");
+ if (DATC & 0x80)
printf (", %d PCICLK data out\n", ((DATC >> 5) & 0x3) + 1);
printf ("SiS 5591 status: %s drive %d postwrite %s, prefetch %s prefetch count
is %d\n",
unitno < 2 ? "primary" : "secondary",
--tKW2IUtsqtDRztdT--
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
