Re: repeatable crash in -current (softupdates, NFS)

[Viren R.Shah]

>>>>> "Matt" == Matthew Dillon <[EMAIL PROTECTED]> writes:

 Matt>     I've added a little cleanup to this patch.  Viren, please try this 
 Matt>     patch.

 Matt>                                  -Matt
 Matt>                                  Matthew Dillon 
 Matt>                                  <[EMAIL PROTECTED]>

 Matt> Index: nfs_vnops.c
 Matt> ===================================================================
 Matt> RCS file: /FreeBSD/FreeBSD-CVS/src/sys/nfs/nfs_vnops.c,v
 Matt> retrieving revision 1.146
 Matt> diff -u -r1.146 nfs_vnops.c
 Matt> --- nfs_vnops.c  1999/11/27 18:14:41     1.146
 Matt> +++ nfs_vnops.c  1999/11/29 23:23:05
 Matt> @@ -1806,11 +1806,10 @@
 Matt>                  txdr_nfsv2time(&vap->va_mtime, &sp->sa_mtime);
 Matt>          }
 Matt>          nfsm_request(dvp, NFSPROC_SYMLINK, cnp->cn_proc, cnp->cn_cred);
 Matt> -        if (v3) {
 Matt> -                if (!error)
 Matt> -                        nfsm_mtofh(dvp, newvp, v3, gotvp);
 Matt> +        if (!error)
 Matt> +                nfsm_mtofh(dvp, newvp, v3, gotvp);
                                        ^^^^^^^^^^

Should that still be "v3"? Since you moved it out of the "if (v3)"
block, sholudn't it say something else?

Viren
-- 
Viren Shah                    | "You can't trust code that you did not totally
Research Associate, RST Inc.  | create yourself. (Especially code from 
[EMAIL PROTECTED]             | companies that employ people like me.)"
http://www.rstcorp.com/~vshah | - Ken Thompson "Reflections on Trusting Trust"


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message