Bruce Evans wrote:
> On Fri, 12 Nov 1999, Peter Jeremy wrote:
>
> > On 1999-Nov-12 12:35:01 +1100, Mark Newton wrote:
> > >The problem is that the BUS_SETUP_INTR() method for ISA seems to
> > >absolutely require the specification of an IRQ, even though IRQ
> > >specification is absolutely prohibited for non-master ports in
> > >AST-compatible multi-port sio cards. Gah.
>
> This is fixed differently (directly in the driver) in nsio (dev/sio/sio.c)
> rev.1.267. Both fixes are probably necessary and more or less correct.
> Drivers shouldn't attempt to register null interrupts, and attempting
> this probably shouldn't cause panics.
>
> > As an aside, why doesn't our SIO driver work with ports that don't
> > have interrupts?
>
> Same problem. Ports that don't have interrupts give polled mode, and
> the driver shouldn't attempt to register the null interrupts for polled
> mode, but this was broken when the driver was converted to new-bus.
>
> > >I'm not completely sure that this patch does the right thing
> >
> > Since your patch effectively turns isa_setup_intr() into a nop for
> > this case, a better patch would seem to be to skip the call to
> > BUS_SETUP_INTR() (and presumably bus_alloc_resource()) at the end
> > of sioattach() when you're attaching a slave SIO port.
>
> nsio still has the bus_alloc_resource(). This seems to be a harmless
> but bogus no-op if the resource isn't there.
>
> Bruce
I think I've got all this fixed (or closer to being fixed) in a merge of
some nsio stuff back into sio.c so nsio.c can be zapped for now.
Cheers,
-Peter
--
Peter Wemm - [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
