Bugzilla Automation <[email protected]> has asked freebsd-chromium (Nobody) <[email protected]> for maintainer-feedback: Bug 289781: www/ungoogled-chromium: Failed to build due to missing PaswordProtectionTrigger https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289781
--- Description --- It seems that given this patch: https://github.com/ungoogled-software/ungoogled-chromium/blob/4a2db8bd77a050ffa 882634a6ae622570bcdd037/patches/core/ungoogled-chromium/fix-building-without-sa febrowsing.patch#L1908 That ungoogled-chromium is built without safebrowsing. But looking at the error here: ../../components/enterprise/browser/reporting/report_util.cc:84:34: error: no member named 'PasswordProtectionTrigger' in namespace 'safe_bro wsing' 84 | std::optional<safe_browsing::PasswordProtectionTrigger> trigger) { | ~~~~~~~~~~~~~~~^ ../../components/enterprise/browser/reporting/report_util.cc:89:25: error: no member named 'PasswordProtectionTrigger' in namespace 'safe_bro wsing' 89 | case safe_browsing::PasswordProtectionTrigger::PASSWORD_PROTECTION_OFF: | ~~~~~~~~~~~~~~~^ ../../components/enterprise/browser/reporting/report_util.cc:91:25: error: no member named 'PasswordProtectionTrigger' in namespace 'safe_bro wsing' 91 | case safe_browsing::PasswordProtectionTrigger::PASSWORD_REUSE: | ~~~~~~~~~~~~~~~^ ../../components/enterprise/browser/reporting/report_util.cc:93:25: error: no member named 'PasswordProtectionTrigger' in namespace 'safe_bro wsing' 93 | case safe_browsing::PasswordProtectionTrigger::PHISHING_REUSE: | ~~~~~~~~~~~~~~~^ ../../components/enterprise/browser/reporting/report_util.cc:95:25: error: no member named 'PasswordProtectionTrigger' in namespace 'safe_bro wsing' 95 | case safe_browsing::PasswordProtectionTrigger:: | ~~~~~~~~~~~~~~~^ ../../components/enterprise/browser/reporting/report_util.cc:97:7: error: use of undeclared identifier 'NOTREACHED' 97 | NOTREACHED(); | ^ ../../components/enterprise/browser/reporting/report_util.cc:114:20: error: no type named 'SafeBrowsingState' in namespace 'safe_browsing' 114 | safe_browsing::SafeBrowsingState level) { | ~~~~~~~~~~~~~~~^ ../../components/enterprise/browser/reporting/report_util.cc:116:25: error: no member named 'SafeBrowsingState' in namespace 'safe_browsing' 116 | case safe_browsing::SafeBrowsingState::NO_SAFE_BROWSING: | ~~~~~~~~~~~~~~~^ ../../components/enterprise/browser/reporting/report_util.cc:118:25: error: no member named 'SafeBrowsingState' in namespace 'safe_browsing' 118 | case safe_browsing::SafeBrowsingState::STANDARD_PROTECTION: | ~~~~~~~~~~~~~~~^ ../../components/enterprise/browser/reporting/report_util.cc:120:25: error: no member named 'SafeBrowsingState' in namespace 'safe_browsing' 120 | case safe_browsing::SafeBrowsingState::ENHANCED_PROTECTION: It seems that the port reverted part of disabling SafeBrowsing in the update to 140.0.7339.185 See: https://cgit.freebsd.org/ports/diff/www/ungoogled-chromium/files/patch-componen ts_enterprise_browser_reporting_report__util.cc?id=c1eb6b5d114ecc2d016db16a00ce ce4fd40f53f0
