Re: [PATCH 01/11] fortran: array descriptor: Use the setter to modify the offset

[Tobias Burnus]

Mikael Morin wrote:

From: Mikael Morin <mik...@gcc.gnu.org>

Regression tested on powerpc64le-unknown-linux-gnu.  OK for master?

LGTM. The code already used 23 _set and 10 _get calls – and
outside the new trans-descriptor.cc function, only one
non _set/_get remained prior to this patch, which is now
replaced by a _set call.

Use the setter function to generate code modifying the array descriptor
offset and remove from the public API the function giving direct access to
that field.

gcc/fortran/ChangeLog:

        * trans-array.cc (gfc_alloc_allocatable_for_assignment): Use the
        setter function to generate a modification of the array descriptor
        offset.
        * trans-descriptor.cc (gfc_conv_descriptor_offset): Make static and
        rename ...
        (conv_descriptor_offset): ... to this.
        (gfc_conv_descriptor_offset_get,
        gfc_conv_descriptor_offset_set): Update callers.
        * trans-descriptor.h (gfc_conv_descriptor_offset): Remove
        declaration.

Thanks,

Tobias