Hi Jerry,
thanks for testing. I have fixed IMO most of the whitespace issues in the
patch attached to this mail:
https://gcc.gnu.org/pipermail/fortran/2025-June/062349.html
About the 32 vs. 64 bit versions of the libraries: I never got in touch with
that. I am doing the same as for caf_single. In fact I copied the Makefile.am
portion of caf_single and changed it to generate caf_shmem. Do you get both
versions for caf_single? Did you try a clean rebuild? Can anyone give me a
pointer on what I do wrong here?
Regards,
Andre
On Wed, 25 Jun 2025 13:21:29 -0700
Jerry D <[email protected]> wrote:
> On 6/24/25 11:49 PM, Andre Vehreschild wrote:
> > Hi Jerry,
> >
> > thank you very much. Just try it. I can only imagine that Paul had a somehow
> > corrupted build directory or left overs from some previous build. I am still
> > wondering, that I got no automated mail from the build hosts, but I can
> > imagine, that they get issues with a series of patches, that build upon each
> > other.
> >
> > Just try it. The more feedback, the better.
> >
> > Regards,
> > Andre
> >
> > On Tue, 24 Jun 2025 11:07:23 -0700
> > Jerry D <[email protected]> wrote:
> >
> >> On 6/24/25 6:09 AM, Andre Vehreschild wrote:
> >>> Hi all,
> >>>
> >>> this series of patches (six in total) adds a new coarray backend library
> >>> to libgfortran. The library uses shared memory and processes to implement
> >>> running multiple images on the same node. The work is based on work
> >>> started by Thomas and Nicolas Koenig. No changes to the gfortran compile
> >>> part are required for this.
> >>
> >> --- snip ---
> >>
> >> Hi Andre,
> >>
> >> Thank you for this work. I have been wanting this functionality for
> >> several years!
> >>
> >> I will begin reviewing as best I can. I did see Paul's initial comment
> >> so your feedback on that would be appreciated.
> >>
> >> Best regards,
> >>
> >> Jerry
> >
> >
>
> I was able to apply the patches without any issues. I did see some
> trailing white space in a few places.
>
> In running the testsuite the test lock_1.f90 test fails, unable to link
> to the new library.
>
> After some brief investigation, it appears the the 64-bit version of the
> new library is not created or installed. I did find the 32-bit version.
>
> So something not right in the make mechanisms.
>
> Looking ahead a bit I was wondering if one could enable co-array if
> co-array syntax is seen at the parsing phase of the compiler, if no
> --fcoarray= has been seen, default it to 'single' and issue a NOTE to
> the user "-fcoarray=single enabled, use -fcoarray=[none, shmem, lib] to
> override"
>
> Regards,
>
> Jerry
>
>
>
>
--
Andre Vehreschild * Email: vehre ad gmx dot de
