Re: [Fortran, Patch, Teams, 0/5] Improve on Fortran 2018 teams support

[Jerry D]

On 4/13/25 11:47 PM, Andre Vehreschild wrote:
Hi Jerry,
thank you very much for the review.

I would love to fix the nits you found, but I don't see, what you see. Can you
elaborate? May be some mail client has removed something, or I am missing
something. Are you commenting on

  gfc_error (
     "%s argument at %L must be a scalar %s variable of at least kind %d",

that this is formatted like this, i.e. the string in the next line? That is
clang-format's doing. That formatter is getting worse in each iteration.

I see this in the second and third chunk of your comment, too. Is this what you
like me to fix? I just want to prevent overlooking some typo or the like.

Thanks again and regards,
        Andre


Yes, there appears to be some line breaks out of place like this one 
below. I only saw those in the one file after applying the patch. It is 
not critical, so proceed as you prefer.

Thanks,

Jerry

--- snip ---

     gfc_resolve_expr (e);
    if (e
       && (e->ts.type != exp_type || e->ts.kind < exp_kind || e->rank != 0
          || e->expr_type != EXPR_VARIABLE))
      gfc_error (
     "%s argument at %L must be a scalar %s variable of at least kind %d",
        name, &e->where, gfc_basic_typename (exp_type), exp_kind);