Hi Andre,
this patch broke Solaris bootstrap:
/vol/gcc/src/hg/master/local/libgfortran/caf/single.c: In function
‘_gfortran_caf_transfer_between_remotes’:
/vol/gcc/src/hg/master/local/libgfortran/caf/single.c:675:23: error: implicit
declaration of function ‘alloca’ [-Wimplicit-function-declaration]
675 | transfer_desc = alloca (desc_size);
| ^~~~~~
/vol/gcc/src/hg/master/local/libgfortran/caf/single.c:675:23: warning:
incompatible implicit declaration of built-in function ‘alloca’
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/libgfortran/caf/single.c:680:20: warning:
incompatible implicit declaration of built-in function ‘alloca’
[-Wbuiltin-declaration-mismatch]
680 | transfer_ptr = alloca (*opt_dst_charlen * src_size);
| ^~~~~~
make[3]: *** [Makefile:4675: caf/single.lo] Error 1
Solaris needs to include <alloca.h> to get an alloca declaration. While
this could be handled with AC_FUNC_ALLOCA (like libcpp does) or checking
for alloca.h and including it if found (like libssp does), I guess
there's a simpler way: several runtime libs use __builtin_alloca
unconditionally (libgcc, libquadmath, libstdc++-v3).
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
