Re: [PATCH] OpenMP/Fortran: Add missing pop_state in parse_omp_dispatch

[Paul-Antoine Arras]

Pushed to master as obvious. This should fix PR118714.

On 31/01/2025 11:46, Paul-Antoine Arras wrote:

When the ST_NONE case is taken, the function returns immediately. Not calling
pop_state causes a dangling pointer.

gcc/fortran/ChangeLog:

        * parse.cc (parse_omp_dispatch): Add missing pop_state.
---
  gcc/fortran/parse.cc | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gcc/fortran/parse.cc b/gcc/fortran/parse.cc
index 00cd23d7729..5094d9d3ead 100644
--- a/gcc/fortran/parse.cc
+++ b/gcc/fortran/parse.cc
@@ -6375,7 +6375,10 @@ parse_omp_dispatch (void)

st = next_statement ();

    if (st == ST_NONE)
-    return st;
+    {
+      pop_state ();
+      return st;
+    }
    if (st == ST_CALL || st == ST_ASSIGNMENT)
      accept_statement (st);
    else

--
PA