Hi Paul, thanks for the review. Committed as: gcc-15-4405-ge32fff675c3
Thanks again, Andre On Wed, 16 Oct 2024 14:41:09 +0100 Paul Richard Thomas <paul.richard.tho...@gmail.com> wrote: > Hi Andre, > > The handling of submodules is something of a kludge, especially where > module procedures are concerned, that seems to work OK. Given that, your > patch looks right and is good for mainline. > > Thanks for the patch. > > Paul > > > On Wed, 16 Oct 2024 at 08:21, Andre Vehreschild <ve...@gmx.de> wrote: > > > Hi all, > > > > PING. > > > > Re-Regtested ok again on x86_64-pc-linux-gnu. Ok for mainline? > > > > Regards, > > Andre > > > > On Wed, 25 Sep 2024 12:29:21 +0200 > > Andre Vehreschild <ve...@gmx.de> wrote: > > > > > Hi all and esp. Paul, > > > > > > the attached patch fixes an ICE with coarrays defined in modules and > > then used > > > in submodules. Referencing the variable relied on the curr_module being > > set in > > > the gfc_build_qualified_array routine, which it was not. I therefore > > took the > > > name from the symbol. I don't know if this is correct. Paul any idea? > > You have > > > done the submodule part in the past. I am still not sure, if the coarray > > is > > > exported into the .mod file correctly, because it gets host_assoc set, > > while I > > > would expect it to have use_assoc set. So may be this patch is only > > healing > > > the symptom and not the cause. Could you have a look, please? > > > > > > Regtests ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline? > > > > > > Regards, > > > Andre > > > -- > > > Andre Vehreschild * Email: vehre ad gmx dot de > > > > > > -- > > Andre Vehreschild * Email: vehre ad gmx dot de > > -- Andre Vehreschild * Email: vehre ad gmx dot de