On 1/1/1970 8:00 AM, Thomas Koenig wrote:
Hi Lipeng,
May I know any comment or concern on this patch, thanks for your time :)
Thanks for your patience in getting this reviewed.
A few remarks / questions.
Which strategy is used in this implementation, read-preferring or
write-preferring? And if read-
preferring is used, is there a danger of deadlock if people do unreasonable
things?
Maybe you could explain that, also in a comment in the code >
Can you add some sort of torture test case(s) which does a lot of
opening/closing/reading/writing,
possibly with asynchronous I/O and/or pthreads, to catch possible problems? If
there is a system
dependency or some race condition, chances are that regression testers will
catch this.
Hi Thomas,
Thanks for your time for the review.
Sure, I will add test case according to your suggestions and update the
comment based on the implementation of "read-preferring" strategy.
Thanks,
Lipeng Zhu
With this, the libgfortran parts are OK, unless somebody else has more
comments, so give this a couple
of days. I cannot approve the libgcc parts, that would be somebody else
(Jakub?)
Best regards
Thomas
