Hi Tobias! On 2022-05-13T19:44:51+0200, Jakub Jelinek via Fortran <fortran@gcc.gnu.org> wrote: > On Fri, May 13, 2022 at 07:21:02PM +0200, Tobias Burnus wrote: >> gcc/fortran/ChangeLog: >> >> * trans-openmp.cc (gfc_trans_omp_clauses): When mapping nondescriptor >> array sections, use GOMP_MAP_FIRSTPRIVATE_POINTER instead of >> GOMP_MAP_POINTER for the pointer attachment. >> >> libgomp/ChangeLog: >> >> * testsuite/libgomp.fortran/target-nowait-array-section.f90: New test. > > Not 100% sure if we want to add such a testcase into the testsuite given > that it is not valid OpenMP, but perhaps it is ok as we are testing a QoI.
For non-offloading x86_64-pc-linux-gnu '-m32', I'm occasionally (but very rarely!) seeing this test case FAIL its execution test. Similar can also be seen on occasional reports via <gcc-testresu...@gcc.gnu.org>, <gcc-regress...@gcc.gnu.org>. Grüße Thomas 'libgomp.fortran/target-nowait-array-section.f90': | ! Runs the the target region asynchrolously and checks for it | ! | ! Note that map(alloc: work(:, i)) + nowait should be safe | ! given that a nondescriptor array is used. However, it still | ! violates a map clause restriction, added in OpenMP 5.1 [354:10-13]. | | PROGRAM test_target_teams_distribute_nowait | USE ISO_Fortran_env, only: INT64 | implicit none | INTEGER, parameter :: N = 1024, N_TASKS = 16 | INTEGER :: i, j, k, my_ticket | INTEGER :: order(n_tasks) | INTEGER(INT64) :: work(n, n_tasks) | INTEGER :: ticket | logical :: async | | ticket = 0 | | !$omp target enter data map(to: ticket, order) | | !$omp parallel do num_threads(n_tasks) | DO i = 1, n_tasks | !$omp target map(alloc: work(:, i), ticket) private(my_ticket) nowait | !!$omp target teams distribute map(alloc: work(:, i), ticket) private(my_ticket) nowait | DO j = 1, n | ! Waste cyles | ! work(j, i) = 0 | ! DO k = 1, n*(n_tasks - i) | ! work(j, i) = work(j, i) + i*j*k | ! END DO | my_ticket = 0 | !$omp atomic capture | ticket = ticket + 1 | my_ticket = ticket | !$omp end atomic | !$omp atomic write | order(i) = my_ticket | END DO | !$omp end target !teams distribute | END DO | !$omp end parallel do | | !$omp target exit data map(from:ticket, order) | | IF (ticket .ne. n_tasks*n) stop 1 | if (maxval(order) /= n_tasks*n) stop 2 | ! order(i) == n*i if synchronous and between n and n*n_tasks if run concurrently | do i = 1, n_tasks | if (order(i) < n .or. order(i) > n*n_tasks) stop 3 | end do | async = .false. | do i = 1, n_tasks | if (order(i) /= n*i) async = .true. | end do | if (.not. async) stop 4 ! Did not run asynchronously | end ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
