On Thu, Jun 30, 2022 at 02:30:24PM +0200, Tobias Burnus wrote:
> OK for mainline - or should I put that patch into the bin?
Not sure, the other match* macros also aren't wrappers
around another macro and with the internal macro it means we'll
need to parse more many times (even when we then fold the conditions quite
early).
> +/* Like match, but with some special handling:
> + - dosimd - if false, don't do anything if not -fopenmp,
> + otherwise do match_word_omp_simd matching
> + - if dospec_only: if spec_only, goto do_spec_only after matching.
> +
> + If the directive matched but the clauses failed, do not start
> + matching the next directive in the same switch statement. */
> +
> +#define match_internal(match_simd, match_spec_only, keyword, subr, st)
> \
It at least should be matcho_internal or have the OpenMP stuff in the name
somehow, because it is quite OpenMP specific and isn't used by match or
matcha etc.
> +/* Like match. Does simd matching; sets flag simd_matched if keyword
> matched. */
Twice missing 2 spaces after .
Jakub
