Re: [PATCH] PR fortran/103588 - ICE: Simplification error in gfc_ref_dimen_size, at fortran/array.c:2407

[Mikael Morin]

Hello,

On 06/12/2021 23:39, Harald Anlauf via Fortran wrote:
diff --git a/gcc/fortran/array.c b/gcc/fortran/array.c
index 5762c8d92d4..5f9ed17f919 100644
--- a/gcc/fortran/array.c
+++ b/gcc/fortran/array.c
@@ -2403,11 +2403,9 @@ gfc_ref_dimen_size (gfc_array_ref *ar, int dimen, mpz_t 
*result, mpz_t *end)
        {
          stride_expr = gfc_copy_expr(ar->stride[dimen]);
-         if(!gfc_simplify_expr(stride_expr, 1))
-           gfc_internal_error("Simplification error");
-
-         if (stride_expr->expr_type != EXPR_CONSTANT
-             || mpz_cmp_ui (stride_expr->value.integer, 0) == 0)
+         if (!gfc_simplify_expr (stride_expr, 1)
+            || stride_expr->expr_type != EXPR_CONSTANT
+            || mpz_cmp_ui (stride_expr->value.integer, 0) == 0)
            {
              mpz_clear (stride);
              return false;

it’s a preexisting problem, but stride_expr should be freed before 
returning false above.

OK with that change.

Thanks.