Hi Tobias, all,

> > In developing the patch I encountered a difficulty with testcase
> > dec_structure_6.f90, which uses a DEC extension, namelist "old-style
> > CLIST initializers in STRUCTURE".  I could not figure out how to
> > determine the shape of the initializer; it seemed to be always zero.
> > I've added code to accept this, but only under -fdec-structure, and
> > added a TODO in a comment.  If somebody reading this could give me
> > a hint to solve end, I would adjust the patch accordingly.
> 
> See attached patch – it does initialize the variables similarly to other
> shapes in that file, except that it has to take the shape from the LHS
> as seemingly (same testfile) having a 1-dim array can be used to
> initialize a 2-dim array.
> 
> You can approve that patch and integrate it then in your own patch :-)

your fix to match_clist_expr LGTM.  I can really use it.

> LGTM – with the DECL exception removed from resolve.c.

I've removed the DEC exception, cleaned up, regtested again.

Committed and pushed:

https://gcc.gnu.org/g:1e819bd95ebeefc1dc469daa1855ce005cb77822

Thanks,
Harald

> Thanks,
> 
> Tobias
> 
> PS: Without the auto-reshape part, a simple 'gfc_array_size (expr,
> &expr->shape[0]))" would have been sufficient.
> -----------------
> Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 
> München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas 
> Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht 
> München, HRB 106955
>

Reply via email to