Hi, I share the concerns to make these constants public.
In our app "fluidsynth" is just one kind of virtual midi device out of many others. Other midi devices are keyboards, musical instruments with midi interfaces, DAWs (Digital Audio Workstation), other synthesizers like "Mircosoft Wavetable Synth", CoolSoft etc. For all these midi devices this set of midi event definitions is required. Using the fluidsynth's constants for events to/from non-fluidsynth devices does not make sense at all and may result in an unmanageable library dependency. Midi devices have to comply with the official midi spec (see https://www.midi.org/specifications). E.g. a keyboards manufacturer confirms that the keyboard complies with this spec but the keyboard manufacturer does not deliver a C-header file for software to be able to interface to the keyboard through a midi interface. fluidsynth complies with the midi spec in the same way. Reinhold -----Ursprüngliche Nachricht----- Von: fluid-dev [mailto:fluid-dev-bounces+reinhold=notation....@nongnu.org] Im Auftrag von Tom M. Gesendet: Samstag, 24. November 2018 10:42 An: fluid-dev@nongnu.org Betreff: [fluid-dev] Publish MIDI event constants We have an open pull request that suggests to make various MIDI event constants public: https://github.com/FluidSynth/fluidsynth/pull/468 In particular, enums 'fluid_midi_event_type', 'fluid_midi_control_change' and 'midi_meta_event' are requested to be public. The user argues that all those constants may be used in the midi player callback ( fluid_player_set_playback_callback() ). I understand the need. However this step hasn't been done for >16 years. Perhaps to avoid that fluidsynth becomes a MIDI (parsing) library. So, before making any hasty decision, I would like to ask for opinions on this. Tom _______________________________________________ fluid-dev mailing list fluid-dev@nongnu.org https://lists.nongnu.org/mailman/listinfo/fluid-dev _______________________________________________ fluid-dev mailing list fluid-dev@nongnu.org https://lists.nongnu.org/mailman/listinfo/fluid-dev
