Good to hear.

> so it is higtly dependent of the actual "volume envelope generator"
implementation

You mean volume attenuation via fluid_atten2amp()
<https://github.com/FluidSynth/fluidsynth/blob/360ae041351ff04260eec60ee7230814fe54e51d/src/utils/fluid_conv.c#L193>?
This will become user configurable via "synth.volenv", the default stays
the same as the current default. Shouldnt have too much influence.

> integrating it in the actual code base is not difficult because it is
only an adding that doesn't change any previous FluidSynth functionnality.

I mainly had merge conflicts in mind here, but we'll see.

jjc: it seems you were developing this patch against the lastest version
from the SourceForge git repo, instead of the upstream 1.1.6 release. Is
that correct?

Tom


2017-10-09 16:09 GMT+02:00 Ceresa Jean-Jacques <
jean-jacques.cer...@orange.fr>:

> Hi, Ben and Tom
>
>
>
> I understand that PolyMono patch be scheduled to the next major release
> because it is a large adding.
>
> For this reason , as Tom already know, i intend to help for this.
>
> Note however that even the patch is large, integrating it in the actual
> code base is not difficult because it is only an adding that doesn't change
> any previous FluidSynth functionnality.
>
> Conversely, the important "legato functionnality" of the patch make use of
> FluidSynth real-time capabilties, so it is higtly dependent of the actual
> "volume envelope generator" implementation and i hope seriously this
> generator will be never modified until the next FluidSynth major release.
>
> Ben, i hope you will stay always happy using PolyMono patch within your
> interesting ewi system.
>
> Cheers.
>
> jjc
>
>
>
>
>
> > Message du 08/10/17 10:06
> > De : "Tom M." <tom.m...@googlemail.com>
> > A : "FluidSynth mailing list" <fluid-dev@nongnu.org>
> > Copie à :
> > Objet : Re: [fluid-dev] Poly/Mono in 1.1.7?
>
> >
> >
> No and it wont make it into 1.1.x, too huge. I scheduled this for the next
> major release. Integrating it into the current code base will be a lot of
> work and it also needs to be polished. I dont think I can do this my own,
> so any support on that would be very appreciated:
> >
> > https://github.com/FluidSynth/fluidsynth/issues/158
> >
> >
> Tom
> >
>
> >
> 2017-10-07 23:49 GMT+02:00 Ben Gonzales <b...@gonzos.net>:
> >
>>
>> Has JJC's Polymono patch been incorporated into the latest 1.1.7?
>> >
>> > Ben
>> >
>> >
>> > _______________________________________________
>> > fluid-dev mailing list
>> > fluid-dev@nongnu.org
>> > https://lists.nongnu.org/mailman/listinfo/fluid-dev
>> >
>
>
> >
>
>
>
> _______________________________________________
> fluid-dev mailing list
> fluid-dev@nongnu.org
> https://lists.nongnu.org/mailman/listinfo/fluid-dev
>
>
> _______________________________________________
> fluid-dev mailing list
> fluid-dev@nongnu.org
> https://lists.nongnu.org/mailman/listinfo/fluid-dev
>
>
_______________________________________________
fluid-dev mailing list
fluid-dev@nongnu.org
https://lists.nongnu.org/mailman/listinfo/fluid-dev

Reply via email to