Am 11.12.2016 um 00:05 schrieb lvqcl.mail:
Robert Kausch wrote:
The main issues were inclusion of non-existing Makefile.deps
It does exist in git, but not in flac-1.3.2pre1.tar.xz.
(Here's the list of all files that exist in git but not in
the pre-release tarball:
.gitignore
Makefile.deps
ci\flac-autotool.sh
doc\isoflac.txt
Scripts\cross-build-win-binaries.mk
src\libFLAC\ia32\lpc_asm-unrolled.nasm
src\share\win_utf8_io\Makefile.lite
src\test_libFLAC\matrix
src\utils\flactimer\Makefile.lite
src\utils\loudness\loudness.sci
)
and wrong build order (i.e. trying to build flac
before libFLAC and other dependencies).
Probably Makefile.deps should solve this problem?
Imho it's better to add missing Makefile.deps and
two Makefile.lite files into release tarballs.
Yes, the missing Makefiles solve most of the issues. The patch can be
reduced to the attached version.
I'm not sure about the other files you listed. I guess they should
either be added to the tarball or removed from git.
----
Robert Kausch
[email protected]
diff -Naur flac-1.3.2pre1/build/lib.mk flac-1.3.2pre1+litefix/build/lib.mk
--- flac-1.3.2pre1/build/lib.mk 2016-12-06 09:05:46 +0000
+++ flac-1.3.2pre1+litefix/build/lib.mk 2016-12-11 00:32:22 +0000
@@ -66,7 +66,7 @@
LINKD = $(CC) -shared
endif
-BASE_CFLAGS = -Wall -Wextra $(CONFIG_CFLAGS) -DVERSION=$(VERSION) $(DEFINES) $(INCLUDES)
+BASE_CFLAGS = -Wall -Wextra $(CONFIG_CFLAGS) -DVERSION=$(VERSION) -DPACKAGE_VERSION=$(VERSION) $(DEFINES) $(INCLUDES)
ifeq ($(DEFAULT_BUILD),debug)
CFLAGS := -g -O0 -DDEBUG $(CFLAGS) $(BASE_CFLAGS) -Wmissing-prototypes -Wstrict-prototypes
diff -Naur flac-1.3.2pre1/src/test_streams/Makefile.lite flac-1.3.2pre1+litefix/src/test_streams/Makefile.lite
--- flac-1.3.2pre1/src/test_streams/Makefile.lite 2016-12-06 09:05:46 +0000
+++ flac-1.3.2pre1+litefix/src/test_streams/Makefile.lite 2016-12-11 00:32:22 +0000
@@ -30,9 +30,9 @@
INCLUDES = -I./include -I$(topdir)/include
ifeq ($(OS),Darwin)
- EXPLICIT_LIBS = $(libdir)/libgrabbag.a -lm
+ EXPLICIT_LIBS = $(libdir)/libgrabbag.a $(libdir)/libreplaygain_analysis.a -lm
else
- LIBS = -lgrabbag -lm
+ LIBS = -lgrabbag -lreplaygain_analysis -lm
endif
SRCS_C = \
_______________________________________________
flac-dev mailing list
[email protected]
http://lists.xiph.org/mailman/listinfo/flac-dev
