Baptiste Coudurier <[email protected]> added the comment:
On 12/6/10 11:42 AM, Reimar Döffinger wrote: > > Reimar Döffinger <[email protected]> added the comment: > > On Mon, Dec 06, 2010 at 11:27:26AM +0000, Baptiste Coudurier wrote: >> + // Handles VFR by flushing page because this frame needs to have a >> timestamp >> + if (st->codec->codec_id == CODEC_ID_THEORA && >> + ogg_granule_to_timestamp(oggstream, granule) > >> + ogg_granule_to_timestamp(oggstream, oggstream->last_granule) + 1) { > > Checking the codec_id feels wrong and contradicts the comment... THEORA is the only video codec we support in the ogg muxer currently. > Also should the < case be handled in some special case (no idea it can > even happen). I don't think this can happen, av_write_frame would fail before. [...] ________________________________________________ FFmpeg issue tracker <[email protected]> <https://roundup.ffmpeg.org/issue2398> ________________________________________________
