On Sun, Apr 5, 2020 at 3:13 PM Moritz Barsnick <[email protected]> wrote: > > On Sun, Apr 05, 2020 at 10:28:17 +0530, [email protected] wrote: > > + tile->has_ppt = 1; // this tile has a ppt marker > > +/* Zppt = */ bytestream2_get_byte(&s->g); // Zppt is skipped and not > > used > > I don't know what others think, but, as mentioned in my first review, I > really dislike this style, because it gives the impression that this > line is commented out, when just skimming over the code. > > How about just: > bytestream2_get_byte(&s->g); // skip Zppt > ? > This should do. I'll resubmit. Should I remove other instances of something similar to this in another patch? > Thanks, > Moritz > _______________________________________________ > ffmpeg-devel mailing list > [email protected] > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > [email protected] with subject "unsubscribe".
-- ------------- Gautam | _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
