20/1/20 9:47 am, Carl Eugen Hoyos пишет: > > Am So., 19. Jan. 2020 um 23:44 Uhr schrieb Zane van Iperen > <[email protected]>: >> >> 20/1/20 4:52 am, Carl Eugen Hoyos пишет: > >>>> + argo_asf_parse_file_header(&hdr, p->buf); >>>> + >>>> + if(hdr.magic != ASF_TAG) >>>> + return 0; >>>> + >>>> + if (argo_asf_is_known_version(&hdr)) >>>> + score += 25; >>> >>> Return MAX/2 + 1 in this case, feel free to ignore the other fields. >> >> Isn't that still a relatively low score? > > If (!) an mpeg stream succeeds with a higher score, it is most likely > correct not to detect argo_asf but feel free to add more checks. > Since you check nearly exclusively for zeros (except for the first 32 bits), > please don't make it >75. > > Carl Eugen > _______________________________________________ > ffmpeg-devel mailing list > [email protected] > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > [email protected] with subject "unsubscribe". >
Makes sense, fixed. The maximum possible score now is 61. Zane _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
