Hi, > -----Original Message----- > From: ffmpeg-devel <[email protected]> On Behalf Of Fu, > Linjie > Sent: Sunday, December 15, 2019 10:02 > To: FFmpeg development discussions and patches <ffmpeg- > [email protected]>; [email protected]; [email protected]; Pierre- > [email protected] > Subject: Re: [FFmpeg-devel] [PATCH 1/4] tests/checkasm: add overflow test > for hevc_add_res > > Hi, > > > -----Original Message----- > > From: Fu, Linjie <[email protected]> > > Sent: Wednesday, December 11, 2019 16:46 > > To: [email protected] > > Cc: Fu, Linjie <[email protected]>; Xu, Guangxin <[email protected]> > > Subject: [PATCH 1/4] tests/checkasm: add overflow test for hevc_add_res > > > > Add overflow test for hevc_add_res when int16_t coeff = -32768. > > The result of C is good, while ASM is not. > > > > To verify: > > make fate-checkasm-hevc_add_res > > ffmpeg/tests/checkasm/checkasm --test=hevc_add_res > > > > ./checkasm --test=hevc_add_res > > checkasm: using random seed 679391863 > > MMXEXT: > > hevc_add_res_4x4_8_mmxext (hevc_add_res.c:69) > > - hevc_add_res.add_residual [FAILED] > > SSE2: > > hevc_add_res_8x8_8_sse2 (hevc_add_res.c:69) > > hevc_add_res_16x16_8_sse2 (hevc_add_res.c:69) > > hevc_add_res_32x32_8_sse2 (hevc_add_res.c:69) > > - hevc_add_res.add_residual [FAILED] > > AVX: > > hevc_add_res_8x8_8_avx (hevc_add_res.c:69) > > hevc_add_res_16x16_8_avx (hevc_add_res.c:69) > > hevc_add_res_32x32_8_avx (hevc_add_res.c:69) > > - hevc_add_res.add_residual [FAILED] > > AVX2: > > hevc_add_res_32x32_8_avx2 (hevc_add_res.c:69) > > - hevc_add_res.add_residual [FAILED] > > checkasm: 8 of 14 tests have failed > > > > Signed-off-by: Xu Guangxin <[email protected]> > > Signed-off-by: Linjie Fu <[email protected]> > > --- > > tests/checkasm/hevc_add_res.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tests/checkasm/hevc_add_res.c > > b/tests/checkasm/hevc_add_res.c > > index e92c6b4..a6e3b8a 100644 > > --- a/tests/checkasm/hevc_add_res.c > > +++ b/tests/checkasm/hevc_add_res.c > > @@ -58,6 +58,7 @@ static void check_add_res(HEVCDSPContext h, int > > bit_depth) > > > > randomize_buffers(res0, size); > > randomize_buffers2(dst0, size); > > + res0[0] = 0x8000;// overflow test > > memcpy(res1, res0, sizeof(*res0) * size); > > memcpy(dst1, dst0, sizeof(int16_t) * size); > > > > -- > > 2.7.4 > A kindly ping. > Any comments towards this? > Ping, and looking forward to any feedbacks.
This overflow does affect the decode of the clips with coeff=-32768, and makes it difficult(unless by --disbale-asm) to use software decoded result as a reference for comparation with the hardware decoder. - linjie _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
