On Tue, May 21, 2019 at 11:34:34AM +0200, Tomas Härdin wrote: > tis 2019-05-21 klockan 17:44 +1000 skrev Peter Ross: > > --- > > > > what's changed: > > * apply #if CONFIG_VP4_DECODER around large vp4 code blocks > > * improved vp4_read_mb_value thanks to reminars suggestions > > * improved configure vp3_decoder_select
> > +#if CONFIG_VP4_DECODER
> > + if (s->version >= 2) {
> > + int mb_height, mb_width;
> > + int mb_width_mul, mb_width_div, mb_height_mul,
> > mb_height_div;
> > +
> > + mb_height = get_bits(&gb, 8);
> > + mb_width = get_bits(&gb, 8);
> > + if (mb_height != s->macroblock_height ||
> > + mb_width != s->macroblock_width)
> > + av_log(s->avctx, AV_LOG_WARNING, "VP4 header: Warning,
> > macroblock dimension mismatch");
> > +
> > + mb_width_mul = get_bits(&gb, 5);
> > + mb_width_div = get_bits(&gb, 3);
> > + mb_height_mul = get_bits(&gb, 5);
> > + mb_height_div = get_bits(&gb, 3);
> > + if (mb_width_mul != 1 || mb_width_div != 1 ||
> > mb_height_mul != 1 || mb_height_div != 1)
> > + av_log(s->avctx, AV_LOG_WARNING, "VP4 header:
> > Warning, unexpected macroblock dimension multipler/divider");
> > +
> > + if (get_bits(&gb, 2))
> > + av_log(s->avctx, AV_LOG_WARNING, "VP4 header: Warning,
> > unknown bits set");
>
> Maybe these should be errors and/or requests for samples? It macroblock
> count changes that may indicate a resolution change
agree. and no need for "VP4...:" as it will print the context as vp4.
other items fixed. thanks.
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
