On 5/19/19, Marton Balint <[email protected]> wrote: > > > On Sun, 19 May 2019, Paul B Mahol wrote: > >> On 5/19/19, Marton Balint <[email protected]> wrote: >>> Fixes infinte loop with -vf loop=loop=1. >>> >>> Possible regression since ef1aadffc785b48ed62c45d954289e754f43ef46. >>> >>> Signed-off-by: Marton Balint <[email protected]> >>> --- >>> libavfilter/f_loop.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/libavfilter/f_loop.c b/libavfilter/f_loop.c >>> index d9d55f9837..3da753dd1e 100644 >>> --- a/libavfilter/f_loop.c >>> +++ b/libavfilter/f_loop.c >>> @@ -343,7 +343,7 @@ static int activate(AVFilterContext *ctx) >>> >>> FF_FILTER_FORWARD_STATUS_BACK(outlink, inlink); >>> >>> - if (!s->eof && (s->nb_frames < s->size || !s->loop)) { >>> + if (!s->eof && (s->nb_frames < s->size || !s->loop || !s->size)) { >>> ret = ff_inlink_consume_frame(inlink, &frame); >>> if (ret < 0) >>> return ret; >>> -- >>> 2.16.4 >>> >>> _______________________________________________ >>> ffmpeg-devel mailing list >>> [email protected] >>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>> >>> To unsubscribe, visit link above, or email >>> [email protected] with subject "unsubscribe". >> >> I think better fix is to change default and minimal allowed loop size to >> 1. >> Does that sounds ok to you? > > Well, looping the whole length of the input would be more intuitive to me > as the default.
That would require infinite memory. > > Regards, > Marton > _______________________________________________ > ffmpeg-devel mailing list > [email protected] > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > [email protected] with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
