On Thu, May 16, 2019 at 6:12 PM Damien Lévin <[email protected]> wrote: > > Thanks Hendrik, > > The documentation from the AVCodecParameters codec_tag changed here (and > not AVCodecContext which you are referring to) seems pretty explicit about > being an AVI fourcc. So I'm not sure I understand why setting the PES > stream_type (ISO/IEC 13818-1, table 2-34) would be more correct. > "Additional information about the codec (corresponds to the AVI FOURCC)." > > If you look at the code from ffprobe.c (which also uses AVCodecParameters) > the assumption is to also have an AVI fourcc. > > /* print AVI/FourCC tag */ > print_str("codec_tag_string", av_fourcc2str(par->codec_tag)); > print_fmt("codec_tag", "0x%04"PRIx32, par->codec_tag); > > I understand that dumping the stream_type can be convenient but that > doesn't seems like the correct behavior. > Let me know what you think. >
Dumping information in there thats not based on the container is always going to be wrong. Why mov tags? Why not riff tags? Or some other random format? It should be container based or empty. And since the container just has the pes stream type, thats what make sense. Always better to convey something then nothing. What are you even trying to fix? - Hendrik _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
