On Tue, May 7, 2019 at 2:04 AM Moritz Barsnick <[email protected]> wrote:
> On Mon, May 06, 2019 at 22:36:41 -0700, Jun Li wrote:
> > +double av_display_rotation_hflip_get(const int32_t matrix[9], int
> *hflip)
> > +{
> > + int32_t m[9];
> > + *hflip = 0;
> > + memcpy(m, matrix, sizeof(int32_t) * 9);
>
> You were asked to avoid this (at another code location though).
> BTW, sizeof(m) would be a better use of sizeof() here. (Or a constant
> for the triple but related use of "9".)
>
> > + return av_display_rotation_get(m);
> > +}
> > \ No newline at end of file
>
> Cosmetic, but please add a line feed in the last line of the file.
>
> Moritz
> _______________________________________________
> ffmpeg-devel mailing list
> [email protected]
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> [email protected] with subject "unsubscribe".
Thanks Moritz for review.
To address the two issues of line feed and "sizeof(m)", I updated the
iteration here: https://patchwork.ffmpeg.org/patch/13029/
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
