> -----Original Message----- > From: ffmpeg-devel [mailto:[email protected]] On Behalf Of > Cld fire > Sent: Monday, April 8, 2019 8:11 AM > To: FFmpeg development discussions and patches <[email protected]> > Subject: Re: [FFmpeg-devel] [PATCH] libavutil/hwcontext_opencl.c: fix bug in > `opencl_get_plane_format` > > > > > For P010, I guess that division needs to round up? > > > > Yep, rounding the division up did the trick; thanks! > > One last observation before I submit a new patch: I actually missed > previously that the order number is still not lining up for the ARGB format > (the order number that maps to ARGB in the code is currently 4123 while the > new method using the offset and depth is ending up with an order number of > 2341). Simply changing the order number that maps to ARGB from 4123 to 2341 > seems to work fine; is it okay to make that change or do the mapping > numbers need to remain exactly the same? I think we don't need to remain exact as before, you can update the case-values accordingly. And 2341 seems correct for ARGB.
Thanks! Ruiling > _______________________________________________ > ffmpeg-devel mailing list > [email protected] > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > [email protected] with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
