2019-03-21 10:06 GMT+01:00, Nicolas George <[email protected]>: > Carl Eugen Hoyos (12019-03-20): >> + if (par->codec_id != AV_CODEC_ID_AAC && par->codec_id != >> AV_CODEC_ID_MP4ALS) { >> + av_log(ctx, AV_LOG_ERROR, "Only AAC, LATM and ALS are >> supported\n"); >> + return AVERROR_INVALIDDATA; >> + } > > I think EINVAL is more correct in this kind of case: EINVAL for invalid > parameters from the application, INVALIDDATA for invalid data from the > files. A quick grep shows it is not the only place this is done like > that. I do not think it is urgent to fix it, just keep it in mind for > later if you agree.
Should be fixed. Thank you, Carl Eugen _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
