On Tue, 15 Jan 2019, Carl Eugen Hoyos wrote:
2019-01-15 14:43 GMT+01:00, Rostislav Pehlivanov <[email protected]>:
On Tue, 15 Jan 2019 at 11:57, Carl Eugen Hoyos <[email protected]> wrote:
2019-01-15 11:30 GMT+01:00, Rostislav Pehlivanov <[email protected]>:
> On Tue, 15 Jan 2019 at 09:24, Shaofei Wang <[email protected]>
wrote:
>> +#if HAVE_THREADS
>> + if (!abr_pipeline) {
>> + ret = reap_filters(1);
>> + } else {
>> + ret = pipeline_reap_filters(1, ifilter);
>> + }
>>
>
> Same.
This hunk should have brackets, it simplifies
debugging and future patches at very little cost.
No, it does not. It wastes a line.
Yes, it "wastes" a line.
But the advantage far outweighs the incredible costs.
Not that I care too much, but I would write this:
ret = abr_pipeline ? pipeline_reap_filters(1, ifilter) : reap_filters(1);
Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
[email protected]
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
