On 05/11/18 15:49, Gyan wrote: > On Mon, Nov 5, 2018 at 9:04 PM Mark Thompson <[email protected]> wrote: > >> On 05/11/18 15:20, Gyan wrote: >>> On Mon, Nov 5, 2018 at 8:23 PM Mark Thompson <[email protected]> wrote: >>> >>>> --- >>>> Updated to add some more explanation of the rate control mode selection. >>>> >>>> >>>> doc/encoders.texi | 108 ++++++++++++++++++++++++++++++++++++++++++++++ >>>> 1 file changed, 108 insertions(+) >>>> >>>> diff --git a/doc/encoders.texi b/doc/encoders.texi >>>> index 1ca0ef1543..f2e4199017 100644 >>>> --- a/doc/encoders.texi >>>> +++ b/doc/encoders.texi >>>> @@ -1370,6 +1370,114 @@ makes it possible to store non-rgb pix_fmts. >>>> >>>> @end table >>>> >>>> +@section libaom-av1 >>>> + >>>> +libaom AV1 encoder wrapper. >>>> + >>>> +Requires the presence of the libaom headers and library during >>>> +configuration. You need to explicitly configure the build with >>>> +@code{--enable-libaom}. >>>> + >>>> +@subsection Options >>>> + >>>> +The wrapper supports the following standard libavcodec options: >>>> >>> >>> Do we really need to duplicate the text for the generic options? That >> will >>> lead to bloat if widely adopted. >> >> Which parts do you object to? This text is trying to explain how the >> standard options apply to libaom and what their defaults are. >> > > Makes sense. But items like g, the color props or profile are covered by > the generic text. Maybe for completeness' sake, we should keep them here. > > LGTM
Applied with minor changes - I removed the colour properties setting because it wasn't adding anything, and I added some more text to the GOP size option to describe the default behaviour. Thanks, - Mark _______________________________________________ ffmpeg-devel mailing list [email protected] http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
